-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readAlexandrovSignatures takes forever #5
Comments
The issue is with this line that was introduced in the recent versions:
The loop just keeps going on and on... |
Dear Komal, that's strange. Could you let me have the signature data file that you're trying to load? This way I can try to replicate the problem. Thanks! |
Sure, thanks for replying. I'll send it shortly. |
Actually, I am trying to load the default COSMIC signatures i.e. just running
However, when I replace the while statement with just |
Dear Komal, That is very strange, the default works perfectly fine for me. If I remember well, the default does actually not require the normalization and it was a later version where the signature vectors didn't add up to precisely 1. But I'm not 100% sure here. In any case: this default is the old version 2 of the COSMIC mutational signatures. It might anyway be better to use the newest version (SBS signatures v3.4) downloaded from the COSMIC website: https://cancer.sanger.ac.uk/signatures/downloads/ Can you please test whether these work for you? Thanks! |
I just tested this but taking forever i.e. never finishes:
It is indeed weird. I can't think of anything else but could be some issue with my package version or a dependency? In either case, if you are able to run it fine, then it is something on my end so I will close this. In the meanwhile, I will continue to use it by commenting out the while statement. Thanks for checking! |
Hi,
I am trying to run
signatures <- decompTumor2Sig::readAlexandrovSignatures()
but it seems to be taking forever. I never faced this issue before - have been using the function for quite a few years. Here is my R session:The text was updated successfully, but these errors were encountered: