-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Images Meeting Minutes #14
Comments
cc @vtikha |
Just to understand, do you think that is an advantage for maintaining this image outside of the robotology-superbuild? I was thinking that we could move it in the robotology-superbuild repo so we that when a new option is added in the robotology-superbuild, it is directly added also in the Docker image, but I do not know if I missing something. |
We discussed this point also regarding the yarp image, so I think we can extend the scope of your question to a more generic: where should we store the images officially supported? The options are:
Both options have pros and cons. One of the pros of the second option what you pointed out. In my opinion, having a single repo helps finding and consuming the images from downstream users, and it centralizes knowledge, infrastructure (e.g. actions for CI/CD), and docker-related ticketing. Having some experience with osrf/docker_images, I think this a reasonable approach. Try to think how to deal with all the tooling of that repo if the images are spread in ROS / ROS2 / Gazebo / ... repos. It's just simpler for users to know a single place to look for if they need to find the Dockerfiles. Another topic discussed with @drdanz is where to push the images. We thought that using the github registry would be a valid alternative to dockerhub, and we left a comment to verify how to push images from this repo to, e.g., the yarp repo. Another option, if we decide to go towards 1, is to deploy them all in the centralized repo as well. I fear that a too fragmented docker situation would complicate things and create confusions. |
We had a small internal meeting discussing the future for docker images for yarp/robotology-superbuild, etc., and we defined a few action points.
docker-images
The text was updated successfully, but these errors were encountered: