diff --git a/doc/release/master/fix_logFowarder_lost_msgs.md b/doc/release/master/fix_logFowarder_lost_msgs.md new file mode 100644 index 00000000000..55a8c10e772 --- /dev/null +++ b/doc/release/master/fix_logFowarder_lost_msgs.md @@ -0,0 +1,10 @@ +fix_logForwarder_lost_msgs {#master} +----------------------- + +## Libraries + +### `os` + +#### `Log` + +* LogForwarder: now using yarp::os::PortWriterBuffer to prevent message loss \ No newline at end of file diff --git a/src/libYARP_os/src/yarp/os/impl/LogForwarder.cpp b/src/libYARP_os/src/yarp/os/impl/LogForwarder.cpp index 8d5e0c533d8..b7d214a177e 100644 --- a/src/libYARP_os/src/yarp/os/impl/LogForwarder.cpp +++ b/src/libYARP_os/src/yarp/os/impl/LogForwarder.cpp @@ -46,8 +46,9 @@ yarp::os::impl::LogForwarder::LogForwarder() if (!outputPort.open(logPortName)) { printf("LogForwarder error while opening port %s\n", logPortName.c_str()); } - outputPort.enableBackgroundWrite(true); + outputPort.addOutput("/yarplogger", "fast_tcp"); + outputPort_buffer.attach(outputPort); started = true; } @@ -55,12 +56,12 @@ yarp::os::impl::LogForwarder::LogForwarder() void yarp::os::impl::LogForwarder::forward(const std::string& message) { mutex.lock(); - static Bottle b; + Bottle& b = outputPort_buffer.get(); b.clear(); std::string port = "[" + outputPort.getName() + "]"; b.addString(port); b.addString(message); - outputPort.write(b); + outputPort_buffer.write(); mutex.unlock(); } diff --git a/src/libYARP_os/src/yarp/os/impl/LogForwarder.h b/src/libYARP_os/src/yarp/os/impl/LogForwarder.h index dd9f8ef3895..5a700da3029 100644 --- a/src/libYARP_os/src/yarp/os/impl/LogForwarder.h +++ b/src/libYARP_os/src/yarp/os/impl/LogForwarder.h @@ -9,6 +9,7 @@ #include #include +#include #include #include @@ -31,6 +32,7 @@ class YARP_os_impl_API LogForwarder std::mutex mutex; yarp::os::Port outputPort; + yarp::os::PortWriterBuffer outputPort_buffer; static bool started; };