Skip to content

Commit 5b4bd49

Browse files
authored
Merge pull request #251 from robotpy/upgrade-pybind11-v3
Upgrade to pybind11 v3 prerelease
2 parents 40aa96c + 8471838 commit 5b4bd49

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

robotpy_build/autowrap/render_pybind11.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -338,6 +338,8 @@ def cls_decl(r: RenderBuffer, cls: ClassContext):
338338
class_params.append(
339339
f"std::unique_ptr<typename {cls.full_cpp_name}, py::nodelete>"
340340
)
341+
else:
342+
class_params.append("py::smart_holder")
341343

342344
if cls.trampoline:
343345
class_params.append(cls.trampoline.var)

robotpy_build/command/build_ext.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@ def _spawn(cmd):
134134
self.compiler._rpy_spawn = self.compiler.spawn
135135
self.compiler.spawn = _spawn
136136
for ext in self.extensions:
137-
ext.define_macros.append(("PYBIND11_USE_SMART_HOLDER_AS_DEFAULT", "1"))
138137
if debug:
139138
ext.define_macros.append(
140139
("PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF", "1")

robotpy_build/pybind11

Submodule pybind11 updated 153 files

tests/test_ft_docs.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def test_docstrings_meth():
3939
def test_docstrings_meth_kwd():
4040
assert inspect.getdoc(ft.DocClass.fn2) == inspect.cleandoc(
4141
"""
42-
fn2(self: rpytest.ft._rpytest_ft.DocClass, from_: int) -> None
42+
fn2(self: rpytest.ft._rpytest_ft.DocClass, from_: typing.SupportsInt) -> None
4343
4444
Function with parameter that's a python keyword
4545
@@ -51,7 +51,7 @@ def test_docstrings_meth_kwd():
5151
def test_docstrings_meth_rename():
5252
assert inspect.getdoc(ft.DocClass.fn3) == inspect.cleandoc(
5353
"""
54-
fn3(self: rpytest.ft._rpytest_ft.DocClass, ohai: int) -> None
54+
fn3(self: rpytest.ft._rpytest_ft.DocClass, ohai: typing.SupportsInt) -> None
5555
5656
Function with renamed parameter
5757

0 commit comments

Comments
 (0)