New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`NetworkError` should be more specific #142

Open

Anton-4 opened this issue Dec 5, 2023 · 0 comments

Collaborator

Anton-4 commented Dec 5, 2023 •

edited

Loading

There can be useful data behind a NetworkError, for example:

hyper::Error(
        Connect,
        ConnectError(
            "dns error",
            Custom {
                kind: Uncategorized,
                error: "failed to lookup address information: Name does not resolve",
            },
        ),
    ),

We should not discard that kind of data.

To start of simple, we can change NetworkError to NetworkError Str.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment