Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for allocation errors #740

Open
gavv opened this issue Jun 23, 2024 · 0 comments
Open

Add unit tests for allocation errors #740

gavv opened this issue Jun 23, 2024 · 0 comments
Labels
easy hacks The solution is expected to be straightforward even if you are new to the project help wanted An important and awaited task but we have no human resources for it yet tests

Comments

@gavv
Copy link
Member

gavv commented Jun 23, 2024

Many pipeline elements take core::IArena as an argument and perform some allocations in constructor. If allocations fails, the convention is to report error (StatusNoMem) via init_status() method.

We need to cover this behavior with unit tests. For each element, we need to add one test that creates the element using mock, which always fails (e.g. core::NoopArena). Then we should check that the element returned StatusNoMem via init_status().

Elements to cover:

  • ChannelMapperReader
  • ChannelMapperWriter
  • PcmMapperReader
  • PcmMapperWriter
  • ProfilingReader
  • ProfilingWriter
  • Mixer
@gavv gavv added tests help wanted An important and awaited task but we have no human resources for it yet easy hacks The solution is expected to be straightforward even if you are new to the project labels Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy hacks The solution is expected to be straightforward even if you are new to the project help wanted An important and awaited task but we have no human resources for it yet tests
Projects
Status: Help wanted
Development

No branches or pull requests

1 participant