Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish pull request that implements pairing heap #750

Open
gavv opened this issue Jul 12, 2024 · 0 comments
Open

Finish pull request that implements pairing heap #750

gavv opened this issue Jul 12, 2024 · 0 comments
Labels
algorithms Algorithms and data structures easy hacks The solution is expected to be straightforward even if you are new to the project help wanted An important and awaited task but we have no human resources for it yet performance

Comments

@gavv
Copy link
Member

gavv commented Jul 12, 2024

We have a task for implementing a priority queue for task scheduling: #379. Discussion showed that a good option for our requirements would be a pairing heap.

There is an abandoned PR that implements it: #584. It implements PairingHeap class, but it's interface should be reworked, as described in PR discussions. The algorithm itself was not carefully reviewed yet.

Also, the class should be adjusted to the new approach that we used for containers: the code should be split into template class PairingHeap and non-template class PairingHeapImpl. Here is an example of this approach: 1, 2.

Benchmark part of the task is optional and can be skipped or done separately.

Please use the linked PR as a base branch unless you want to re-write the whole class from scratch.

@gavv gavv added performance help wanted An important and awaited task but we have no human resources for it yet easy hacks The solution is expected to be straightforward even if you are new to the project algorithms Algorithms and data structures labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithms Algorithms and data structures easy hacks The solution is expected to be straightforward even if you are new to the project help wanted An important and awaited task but we have no human resources for it yet performance
Projects
Status: Help wanted
Development

No branches or pull requests

1 participant