Skip to content

Commit 1bba884

Browse files
authored
chore: drop the Bun support claim and its CI job (#60)
Bun does not load this addon. It refuses any file named better_sqlite3.node ("'better-sqlite3' is not yet supported in Bun"), and a renamed copy built for Bun's ABI (137) fails with undefined V8 symbols: Bun 1.3.5's V8 API layer lacks about 30 of the functions the addon uses, among them FunctionTemplate::InstanceTemplate, Function::Call, the Exception constructors and weak handles. The test-bun job still passed because `bun run test` runs mocha through its `#!/usr/bin/env node` shebang, so the tests ran under Node. Remove the claim from the README, the bun engine from package.json, the Bun troubleshooting section and the test-bun job.
1 parent 05177f6 commit 1bba884

4 files changed

Lines changed: 2 additions & 55 deletions

File tree

‎.github/workflows/build.yml‎

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -101,48 +101,6 @@ jobs:
101101
echo "SELECT 'wrapper test';" | node shell.js
102102
node shell.js --version
103103
104-
test-bun:
105-
strategy:
106-
matrix:
107-
os:
108-
- ubuntu-22.04
109-
- macos-15
110-
- macos-15-intel
111-
bun:
112-
- 1.3.5
113-
name: Testing Bun ${{ matrix.bun }} on ${{ matrix.os }}
114-
runs-on: ${{ matrix.os }}
115-
steps:
116-
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
117-
- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2
118-
with:
119-
bun-version: ${{ matrix.bun }}
120-
- if: ${{ startsWith(matrix.os, 'macos') }}
121-
run: brew install python-setuptools icu4c
122-
- if: ${{ !startsWith(matrix.os, 'macos') }}
123-
run: python3 -m pip install setuptools
124-
- if: ${{ startsWith(matrix.os, 'ubuntu') }}
125-
run: |
126-
sudo apt update
127-
sudo apt install -y gcc-10 g++-10 libreadline-dev libncurses5-dev libicu-dev
128-
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 100 --slave /usr/bin/g++ g++ /usr/bin/g++-10 --slave /usr/bin/gcov gcov /usr/bin/gcov-10
129-
- run: bun install --ignore-scripts
130-
- run: bun run build-debug
131-
- run: bun run test
132-
- run: bun run build-release
133-
- name: Test shell wrapper (Windows)
134-
if: ${{ startsWith(matrix.os, 'windows') }}
135-
shell: powershell
136-
run: |
137-
echo "SELECT 'wrapper test';" | bun shell.js
138-
bun shell.js --version
139-
- name: Test shell wrapper (Unix)
140-
if: ${{ !startsWith(matrix.os, 'windows') }}
141-
shell: bash
142-
run: |
143-
echo "SELECT 'wrapper test';" | bun shell.js
144-
bun shell.js --version
145-
146104
publish:
147105
if: ${{ github.event_name == 'release' }}
148106
name: Publishing to NPM

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ So far the changes are:
44

55
* Build the [bedrock](https://sqlite.org/src/timeline?r=bedrock) branch of SQLite to enable [`begin concurrent`](https://www.sqlite.org/src/doc/begin-concurrent/doc/begin_concurrent.md).
66
* Create a shell too, so we can debug db files created
7-
* Supports both Node.js (22.x, 24.x) and Bun (>=1.1.0) runtimes
7+
* Supports Node.js 22.x and 24.x
88

99
Other changes will be likely be made over time.

‎docs/troubleshooting.md‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,6 @@ If you still have issues, try these steps:
3838
1. Delete your `$HOME/.node-gyp` directory
3939
1. Run `npm install`
4040

41-
## Bun
42-
43-
If you're using Bun and encounter issues:
44-
45-
1. Ensure you're using Bun 1.1.0 or later
46-
2. Try rebuilding: `bun run build-release`
47-
3. Check that prebuilt binaries are available for your platform
48-
49-
Note: Bun uses the same native module system as Node.js, so most Node.js troubleshooting steps apply.
50-
5141
## Still stuck?
5242

5343
Browse [previous installation issues](https://github.com/WiseLibs/better-sqlite3/issues?q=is%3Aissue).

‎package.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
"shell.js"
2222
],
2323
"engines": {
24-
"node": "22.x || 24.x",
25-
"bun": ">=1.1.0"
24+
"node": "22.x || 24.x"
2625
},
2726
"types": "lib/index.d.ts",
2827
"dependencies": {

0 commit comments

Comments
 (0)