Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoproj should run an osdeps operation before a build operation #206

Open
g-arjones opened this issue Jul 21, 2018 · 2 comments
Open

autoproj should run an osdeps operation before a build operation #206

g-arjones opened this issue Jul 21, 2018 · 2 comments

Comments

@g-arjones
Copy link
Contributor

g-arjones commented Jul 21, 2018

If a package is selected for build and one of its dependencies is missing, autoproj will:

  1. Checkout and build the missing dependency if that is a source package;
  2. Do nothing if that is an osdep (the build will most likely fail in this case)

For a more consistent behavior, autoproj should perform an osdeps operation on the packages that are selected for build (this would be disabled by --no-deps/--deps=f).

@doudou
Copy link
Member

doudou commented Jul 23, 2018

I'm not necessarily against this, but only if it is disabled by default and can optionally be enabled.

The problem is that most osdeps are slow, so that would have a non-negligible impact on the build times. If you don't like the inconsistency, then I would simply make build fail even in the source package case, and ask to explicitely run an update.

@g-arjones
Copy link
Contributor Author

only if it is disabled by default

I would be fine with that...

The problem is that most osdeps are slow

I guess there will be some impact on build times indeed.. I will do some testing to see how big they are, maybe it doesn't make sense to have this even as an optional feature.

I would simply make build fail even in the source package case

Not sure.. This is a major change in behavior IMO, I don't know how everyone else would feel about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants