Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoproj installation requires a build environment #288

Open
doudou opened this issue Oct 18, 2019 · 3 comments
Open

autoproj installation requires a build environment #288

doudou opened this issue Oct 18, 2019 · 3 comments

Comments

@doudou
Copy link
Member

doudou commented Oct 18, 2019

There are legitimate uses of autoproj that do not require a build system (e.g. checkout a set of packages, autoproj-sync). Right now, it does need a build system at least for rb-inotify

Since rb-inotify is needed only for autoproj watch, I think it could be made optional. However, I'm not sure how we could do so without breaking existing installs.

If we do assume that watch is used solely with vscode, we can "move" the requirement to rock.vscode, but that feels like breaking backward compatibility in a big way to me.

Thoughts ? @g-arjones

@g-arjones
Copy link
Contributor

I don't think we can fix this without breaking backward compatibility...

Assuming it's not possible, I would make autoproj watch a plugin that would depend on rb-inotify and remove rb-inotify from autoproj. Then we add an API in autoproj to auto install plugins through init.rb scripts and do that in rock.vscode

@doudou
Copy link
Member Author

doudou commented Oct 18, 2019

Then we add an API in autoproj to auto install plugins through init.rb scripts and do that in rock.vscode

Interesting idea the plugin thing ... Maybe simpler: have "default plugins" that are installed unless told otherwise (via e.g. command line option in autoproj_install / autoproj_bootstrap)

Installing plugins via init.rb sounds like a very hard thing to get right

@g-arjones
Copy link
Contributor

have "default plugins" that are installed unless told otherwise (via e.g. command line option in autoproj_install / autoproj_bootstrap)

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants