Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported environment is inconsistent (sometimes) #363

Open
g-arjones opened this issue Dec 19, 2021 · 1 comment
Open

Exported environment is inconsistent (sometimes) #363

g-arjones opened this issue Dec 19, 2021 · 1 comment

Comments

@g-arjones
Copy link
Contributor

g-arjones commented Dec 19, 2021

Exported environment may be different when running autoproj update --config and autoproj envsh. That happens because packages that are not yet imported are excluded from the selection during resolution when running autoproj envsh but that doesn't happen when the environment is exported after an autoproj update --config. The immediate and obvious fix for this is to just skip Package#update_environment while loading packages if a package is not checked out but I'm wondering whether the whole loading of non-imported packages (i.e dependencies processing) should be skipped as well.

@doudou What do you think?

@g-arjones g-arjones assigned doudou and unassigned doudou Dec 19, 2021
@doudou
Copy link
Member

doudou commented Dec 23, 2021

I think what you say makes sense. Maybe just ignoring the non-imported packages would be enough...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants