Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove items from queue if they error x amount of times #197

Open
danstarns opened this issue Jan 9, 2024 · 3 comments
Open

remove items from queue if they error x amount of times #197

danstarns opened this issue Jan 9, 2024 · 3 comments
Assignees

Comments

@danstarns
Copy link
Member

When an error happens in the ingest span queues, it just keeps retrying. TODO @danstarns to populate this more.

@iamYashSinha
Copy link

What should be expected here? Which code file is responsible for this, how one can recreate this issue?

@danstarns
Copy link
Member Author

Hey @iamYashSinha thanks for taking a look.

It looks like for foreign spans(spans that aren't generated from GraphQL debugger trace schema) we try 10 times then stop processing the span

However, for normal spans, located here:

We don't have any retry logic.

We should check that:

  1. undigestable spans don't block the queue
  2. all failing spans are retried a few times before being ingested

Cheers.

@iamYashSinha
Copy link

Please assign me this issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants