Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI tweaks/enhancements #34

Open
0pLuS0 opened this issue Jul 8, 2018 · 60 comments · Fixed by #38
Open

UI tweaks/enhancements #34

0pLuS0 opened this issue Jul 8, 2018 · 60 comments · Fixed by #38
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@0pLuS0
Copy link

0pLuS0 commented Jul 8, 2018

I noticed in the latest version, that a long name is not completely show and the text is cut off.

These are some words I've noticed to give examples. (Also 3 dots trail after the text like below)

Transmission - appears as > Transmissi...

qtfm-6.0.1.tar.gz - appears as > qtfm-6.0.1....

/usr/x86_64-slackware-linux - appears as > x86_64-sla...

Numix Blue Slack.jpg - appears as > Numix Blu...

@rodlie
Copy link
Owner

rodlie commented Jul 8, 2018

6.0 or 6.1?

@0pLuS0
Copy link
Author

0pLuS0 commented Jul 8, 2018

I ran this yesterday and git pull today;

git clone https://github.com/rodlie/qtfm
cd qtfm
git checkout 6.0
git submodule update -i

@rodlie rodlie added this to the 6.1.0 milestone Jul 8, 2018
@rodlie rodlie added the enhancement New feature or request label Jul 8, 2018
@rodlie rodlie self-assigned this Jul 8, 2018
@rodlie
Copy link
Owner

rodlie commented Jul 8, 2018

Ok, then it's not an regression :)

@0pLuS0
Copy link
Author

0pLuS0 commented Jul 8, 2018

ok... 👍

@rodlie
Copy link
Owner

rodlie commented Jul 8, 2018

Some progress on this feature, I'm currently able to word-wrap filenames with space and -, but not others, seems to be a limitation somewhere, but will find a way around it somehow.

@0pLuS0
Copy link
Author

0pLuS0 commented Jul 8, 2018

ok...

@rodlie
Copy link
Owner

rodlie commented Jul 9, 2018

This needs a custom item delegate to get working 100%, not sure I have the time to implement this for 6.1. I will look more into how to solve this next weekend, and (I hope) get it working before 6.1 is released.

@rodlie
Copy link
Owner

rodlie commented Jul 13, 2018

Preview:
qtfm-view

Looks ok?

@0pLuS0
Copy link
Author

0pLuS0 commented Jul 13, 2018

Yeah the screen shot looks nice, now need to test in the Wild... LOL

Keep up the great work!

@rodlie
Copy link
Owner

rodlie commented Jul 13, 2018

More work is needed :) But it will be included in 6.1

@0pLuS0
Copy link
Author

0pLuS0 commented Jul 14, 2018

Ok, sounds good...

One last thing, I know you have 2 branches and you mentioned the differences, but to be honest, at least at this point in time, I'm not seeing any difference when it comes to performance and stability between them, but Master Branch has better options. Personally Master branch just seems like the branch that should alread be released, not 6.0.x...

Hmm

@rodlie
Copy link
Owner

rodlie commented Jul 14, 2018

But master is not done, 6.1 beta will be released next week, final by the end of the month.

6.0 is the current stable until 6.1 is released.

@0pLuS0
Copy link
Author

0pLuS0 commented Jul 14, 2018

ok, hmm odd, Master seemed better to me... :)

Keep up the great work, I can't wait to see more!

@rodlie
Copy link
Owner

rodlie commented Jul 14, 2018

The next version should always be better than the previous :)

qtfm uses the following release cycle:

  • when master is considered stable, branch master to 6.1, then release RC1
  • when 6.1.0 is released the 6.1 branch is considered the stable branch, and should be used by end-users, this branch will only receive bugfixes, how long depends, usually only until the next 6.x release. The "old-stable" 6.0 branch is then considered deprecated.
  • work continue on master (6.2), repeat ...

@0pLuS0
Copy link
Author

0pLuS0 commented Jul 14, 2018

👍

rodlie added a commit that referenced this issue Jul 14, 2018
rodlie added a commit that referenced this issue Jul 14, 2018
@rodlie
Copy link
Owner

rodlie commented Jul 14, 2018

So, the UI modifications seems to work ok in qt5, but there are issues in qt4. Will try to fix qt4 tomorrow.

@0pLuS0
Copy link
Author

0pLuS0 commented Jul 14, 2018

Awesome, and I noticed in the Master, that renaming isn't working, I'm going to test right now in 6.0.3

@rodlie
Copy link
Owner

rodlie commented Jul 14, 2018

renaming works here (master).

@0pLuS0
Copy link
Author

0pLuS0 commented Jul 14, 2018

These were files as numbers, like;

001.jpg
002.jpg
003.jpg

And when I tried to change it, it just kept reverting back, I closed and reopened qtfm and it works now... odd

Something else I just found, when I click an image, I use Viewnior and it pops open saying;

The given locations contain no images

At the terminal I get this;

openInApp "/home/foo/Downloads/AEX Nougat Test.png" "" "image/png" "viewnior.desktop" "/usr/share/applications/viewnior.desktop"
openInApp "viewnior %F" "/home/foo/Downloads/AEX Nougat Test.png" ""
qprocess start detached "viewnior" "/home/foo/Downloads/AEX Nougat Test.png"
running: "viewnior /home/foo/Downloads/AEX Nougat Test.png"

(viewnior:4757): Gtk-CRITICAL **: IA__gtk_action_group_set_sensitive: assertion 'GTK_IS_ACTION_GROUP (action_group)' failed

Would you like a bug report for this?

Thanks

@rodlie
Copy link
Owner

rodlie commented Jul 14, 2018

I see the problem (regarding viewnior), will check the code.

@0pLuS0
Copy link
Author

0pLuS0 commented Jul 14, 2018

Should I delete the above reply and make it into an Issue for your tracking?

rodlie added a commit that referenced this issue Jul 14, 2018
@rodlie
Copy link
Owner

rodlie commented Jul 22, 2018

Well you don't want the directories shifting around, you don't want to leave it like this.

I need to adjust based on filename, currently this is it.

The gap between the directories going left <----> right they go back and forth, close together, then spread out wider, as with issue 2, moving left and right all of them, these both happen at the same time.

This is the same as 2. I adjust the grid based on filename. The longest filename decides the minimum width.

I forgot to ask, with the dracolinux.org domain, you are part of the development? Seems like there hasn't been anything doing on with dracolinux in years...

I am Draco. I don't have time working on it anymore, maybe in the future .....

@rodlie
Copy link
Owner

rodlie commented Jul 22, 2018

8b60d38 should fix .2

@rodlie
Copy link
Owner

rodlie commented Jul 22, 2018

That will break other stuff ..., reverted

@rodlie
Copy link
Owner

rodlie commented Jul 22, 2018

Will fix the width stuff later today (or tomorrow, a bit busy today).

@rodlie
Copy link
Owner

rodlie commented Jul 22, 2018

The width is now static, so items should not move.

rodlie added a commit that referenced this issue Jul 22, 2018
@0pLuS0
Copy link
Author

0pLuS0 commented Jul 22, 2018

Hey,

If I'm jumping to much ahead here on the Master Branch in regards to submitting issues, please let me know? I mean, I keep forgetting, hehe, that you are still working on it, and wondering if I should just wait some period of time before reporting anything, or anything I find as of now you'd like to know?

@rodlie
Copy link
Owner

rodlie commented Jul 22, 2018

Major modifications/features will not be worked on until 6.1 is done. I will release 6.1 beta on Monday, then use the rest of this month to fix bugs (in 6.1). Feel free to add issues, but note that they might not be worked on for a while.

@0pLuS0
Copy link
Author

0pLuS0 commented Jul 22, 2018

Oh sure, I know how it works, I just got all excited forgetting...

Anyhow with regards to the link outline hasn't been detected! this only appears in the Settings when I make any change, then I get this message.

I noticed when I go into a / root directory, maybe because there are a lot of directories under it, like in /etc when I click /etc it takes like 2-3 seconds to open, there's a lag on opening a lot of directories.

Also now the directories move up and down slightly when changing from one to another, no more left & right movement... :)

On the subject again over directories, name lengths are being not cut off, but showing like this now as example;

ScreenShot
s

The s appears under the n center...

I looked through SpaceFM and of course with long names it does the same thing, but it's allowing more characters to appear before getting cut off, so of course I don't really know how this works, but let me give you some ideas of SpaceFM vs QtFM...

SpaceFM
/var/log/
removed_packag
es

/var/log/removed_scripts (appears all on one line)

QtFM
/var/log
removed_pa
ckages

/var/log/
removed_sc
ripts

@rodlie
Copy link
Owner

rodlie commented Jul 22, 2018

Anyhow with regards to the link outline hasn't been detected! this only appears in the Settings when I make any change, then I get this message.

I removed png/svg warnings for qt5, can't do anything with qt4.

Also now the directories move up and down slightly when changing from one to another, no more left & right movement... :)

Something have to move :) The grid is dynamic and has to either base it's size on width or height. The grid is static width x largest height.

I looked through SpaceFM and of course with long names it does the same thing, but it's allowing more characters to appear before getting cut off, so of course I don't really know how this works, but let me give you some ideas of SpaceFM vs QtFM...

I set a static width and the text is wrapped when it is larger than the width, how am I suppose to know where to wrap the text?

I noticed when I go into a / root directory, maybe because there are a lot of directories under it, like in /etc when I click /etc it takes like 2-3 seconds to open, there's a lag on opening a lot of directories.

I don't notice anything, are you running a regular HDD?

Also note, the more features I add or the more stuff I do in the paint function the slower things will go. If 6.1 is not slower than 6.0 it's a win ;)

@0pLuS0
Copy link
Author

0pLuS0 commented Jul 22, 2018

I removed png/svg warnings for qt5, can't do anything with qt4. --- Ok

Something have to move :) The grid is dynamic --- Ok

how am I suppose to know where to wrap the text? -- LOL, well how am I suppose to know too... :)
There's no like Standard on this text wrapping thing?

Actually my box is pretty fast, at least I'd like to think; i7-6700k & Samsung 850Pro SSD 👍

@rodlie
Copy link
Owner

rodlie commented Jul 23, 2018

I will try to get the wrapping better.

You have a much faster machine than me (I develop on a laptop with an i5-2520m & a random Kingston low-end SSD). Maybe test qt5? I noticed that resizing the window in qt4 is slow, while on qt5 it's smooth.

@rodlie rodlie changed the title Long Names Are Cut Off UI tweaks/enhancements Jul 23, 2018
@rodlie rodlie removed this from the 6.1.0 milestone Jul 23, 2018
@rodlie
Copy link
Owner

rodlie commented Jul 23, 2018

Since the original issue has been added to qtfm I renamed this issue.

@0pLuS0
Copy link
Author

0pLuS0 commented Jul 23, 2018

👍

@rodlie
Copy link
Owner

rodlie commented Jul 27, 2018

So, back to word wrap.

If you want static width then the word wrap stay as-is, if you want "smart" word wrap then the width need to be dynamic as well.

@0pLuS0
Copy link
Author

0pLuS0 commented Jul 28, 2018

Hey I'm just an End-User Man! hehe

You the Coder-Man, so I have no idea how it works, all I know is within all my years in Linux and the mass amount of times over these years I've used various file managers, all of them have the distance, width, whatever is it, remain, and look clean...

It's up to you! :)

@0pLuS0
Copy link
Author

0pLuS0 commented Aug 14, 2018

@rodlie Congrats on the 6.1.0 release! It's looking nice.

I wasn't sure if on this release, or in the future, but I wanted to let you know, I still see the directories shifting around slightly when moving around through them, but not as bad before. I compiled against qt-4.8.7.

Keep up the great work!

@rodlie
Copy link
Owner

rodlie commented Aug 14, 2018

I know, I tried to make it better than it was, but it's not perfect. I will try to fix this for 6.2, and if possible backport to 6.1.

I'm a bit busy with other project this month, but will continue on 6.2 by the end of this month (critical issues in 6.1 will be fixed when reported/found).

6.2 will feature some major changes to get issue #31 working, and will probably take most of next month to get stable/usable.

Btw, qtfm 6.1.x will be available in the next SlackBuilds update (https://slackbuilds.org/ready/).

@0pLuS0
Copy link
Author

0pLuS0 commented Aug 15, 2018

Sounds good, nice on SBo too! :)

Keep up the great work, Linux could use a Killer Light Weight FM!

@rodlie rodlie added this to the 7.0.0 milestone Sep 5, 2018
@Tatsh
Copy link
Contributor

Tatsh commented Dec 21, 2018

I think the file listing needs something to indicate that a double-click/click actually happened and the file will be opening. On macOS Finder, the icon expands and then fades out quickly.

@rodlie
Copy link
Owner

rodlie commented Dec 21, 2018

Yeah, there are several UI tweaks that are needed.

New development has stalled a bit, mostly due to the amount of bugs found in 6.1. The 6.1 branch (as of 6.1.5) seems stable now, so I will start work on 6.2 soon.

Highest priority is a proper file copy/move dialog with support for multiple instances. Then I will add the remaining open issues for 6.2.

I would like to get NetBSD and macOS (if possible, at least as a "tech-preview") support in 6.2.

Major changes will have to wait until v7 (I will re-write the main GUI).

I'm currently busy with another project, but will try to get most things done before the end of 2018.

@0pLuS0
Copy link
Author

0pLuS0 commented Dec 21, 2018

Haven't played with qtfm in ages, if I get some time I'll play again...

@rodlie
Copy link
Owner

rodlie commented Jan 14, 2019

@0pLuS0 : We are still at 6.1, so not that much to test (if you find bugs great). Major changes will not happen until v7, since I need to get rid of a lot of "legacy" code to implement the remaining feature requests. Sadly I have limited time to dedicate to this project...

@imrn
Copy link

imrn commented Feb 2, 2019

Well, this may be off topic but distruptions can be productive in unexpected ways.

@rodlie: Did you ever think about building a qt "panel" application such as tint2,
lxqt4-panel, xfce4-panel, etc? You may wonder why I've made such a suggestion.

Applications/mimes (that are already related with many issues on qtfm) are
also related with a panel's application menu. I'd admit that, they are not
directly related but a satisfying and customizable application access is still
missing from the linux desktop. I think problem is a close relative of the
app/mime issues for the fm.

Given that you've already have https://github.com/rodlie/powerkit in the
notifications area and my issue #100, I would say you are already in navigating in
desktop waters. (Additionally, I only have the clock, window buttons as extras on
my panel.)

If you find this post useful and want to keep it around as a seperate issue or even a
new project I'd happily want to participate in that.

@rodlie
Copy link
Owner

rodlie commented Feb 3, 2019

I currently use tint2 as panel and it works great for my use, creating "another" panel is not something I have planned, but I'm open for suggestions.

@imrn
Copy link

imrn commented Feb 3, 2019

Ok then. First things first: I'd be happy to see qtfm having some
good enough application/mime/desktop management functionalities first.

Additionally, let me paint a futuristic/bloated desktop fm picture here: ;)

  • Customizable Buttons: May be in the form of a tree.
  • A menu and/or bar and/or side panel showing child processes
    launched via double clicks, sendto context menu, clicking on
    custom buttons or dragging files/dirs on them.
  • Ability to manage/minimize/maximize child processes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants