Revert from pre-commit to ci/scripts/python_test_type_annotations.sh

Author: rok

.pre-commit-config.yaml

@@ -188,66 +188,6 @@ repos:
           ?^python/pyarrow/util\.py$|
           ?^python/pyarrow/vendored/|
           )
-  - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.15.0
-    hooks:
-      - id: mypy
-        alias: python
-        name: Python (Stubs) Type Check (mypy)
-        args:
-          - "--config-file=python/pyproject.toml"
-          - "python/pyarrow-stubs"
-        files: >-
-          ^python/pyarrow-stubs/
-        pass_filenames: false
-        additional_dependencies:
-          - fsspec
-          - pandas-stubs
-          - scipy-stubs
-          - types-cffi
-          - types-psutil
-          - types-requests
-          - types-python-dateutil
-  - repo: https://github.com/RobertCraigie/pyright-python
-    rev: v1.1.408
-    hooks:
-      - id: pyright
-        alias: python
-        name: Python (Stubs) Type Check (pyright)
-        args:
-          - "--project=python/pyproject.toml"
-        files: >-
-          ^python/pyarrow-stubs/
-        pass_filenames: false
-        env:
-          PYRIGHT_PYTHON_FORCE_VERSION: latest
-        additional_dependencies:
-          - fsspec
-          - pandas-stubs
-          - scipy-stubs
-          - types-cffi
-          - types-psutil
-          - types-requests
-          - types-python-dateutil
-  - repo: local
-    hooks:
-      - id: ty
-        alias: python
-        name: Python (Stubs) Type Check (ty)
-        language: python
-        entry: ty check python/pyarrow-stubs
-        files: >-
-          ^python/pyarrow-stubs/
-        pass_filenames: false
-        additional_dependencies:
-          - ty
-          - fsspec
-          - pandas-stubs
-          - scipy-stubs
-          - types-cffi
-          - types-psutil
-          - types-requests
-          - types-python-dateutil
   - repo: local
     hooks:
       - id: lintr

ci/scripts/python_test_type_annotations.sh

@@ -0,0 +1,42 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -ex
+pyarrow_dir=${1}
+
+if [ "${PYARROW_TEST_ANNOTATIONS}" == "ON" ]; then
+  if [ -n "${ARROW_PYTHON_VENV:-}" ]; then
+    . "${ARROW_PYTHON_VENV}/bin/activate"
+  fi
+
+  # Install library stubs. Note some libraries contain their own type hints so they need to be installed.
+  pip install fsspec pandas-stubs scipy-stubs types-cffi types-psutil types-requests types-python-dateutil
+
+  # Install type checkers
+  pip install mypy pyright ty
+
+  # Run type checkers
+  pushd ${pyarrow_dir}
+  mypy
+  pyright
+  ty check;
+  popd
+else
+  echo "Skipping type annotation tests";
+fi

compose.yaml

@@ -1530,13 +1530,15 @@ services:
       BUILD_DOCS_CPP: "ON"
       BUILD_DOCS_PYTHON: "ON"
       PYTEST_ARGS: "--doctest-modules --doctest-cython"
+      PYARROW_TEST_ANNOTATIONS: "ON"
     volumes: *conda-volumes
     command:
       ["/arrow/ci/scripts/cpp_build.sh /arrow /build &&
         /arrow/ci/scripts/python_build.sh /arrow /build &&
         pip install -e /arrow/dev/archery[numpydoc] &&
         archery numpydoc --allow-rule GL10,PR01,PR03,PR04,PR05,PR10,RT03,YD01 &&
-        /arrow/ci/scripts/python_test.sh /arrow"]
+        /arrow/ci/scripts/python_test.sh /arrow &&
+        /arrow/ci/scripts/python_test_type_annotations.sh /arrow/python"]
 
   conda-python-dask:
     # Possible $DASK parameters: