[@rollup/plugin-commonjs]: dynamically requiring a built-in node.js module in an esm script will always throw

[perrin4869]

• Rollup Plugin Name:@rollup/plugin-commonjs
• Rollup Plugin Version: 25.0.7
• Rollup Version: 4.9.6
• Operating System (or Browser): slackware64-current
• Node Version: 20
• Link to reproduction (⚠️ read below): fix: explicitly import http and https modules due to bundler limitations nock/nock#2586

Expected Behavior

Doing a dynamic require of a bulit-in node module should succeed, regardless of the settings of dynamicRequireTargets, ignoreDynamicRequire.

Actual Behavior

The dynamic require will throw in all possible configurations of these settings.

Additional Information

I encountered this issue while bundling the latest version of nock (13.5.1).
It does a dynamic require of http and https, but this require will always throw if the target is an esm module run in node.js.
If ignoreDynamicRequire is false, it'll throw with Could not dynamically require \"http\". Please configure the dynamicRequireTargets or/and ignoreDynamicRequires option of @rollup/plugin-commonjs appropriately for this require call to work.. If ignoreDynamicRequire is true, it will throw due to require not being defined inside the esm module.
It should be relatively easy to fix it so this behavior is supported, but probably best done by someone familiar with the codebase 😅

[perrin4869]

@lukastaegert I think adding support for dynamically importing builtin node modules would be the solution here?

dynamicRequireTargets: ['http', 'https'],

This doesn't work right, because all dynamicRequireTargets need have a root directory in common. I tried to put together a PR implementing something of the sort, but it's trickier/more complicated than I imagined... I'd need a way to get the require$$x for a given module, and add that module to the exports, and I'm not familiar enough with the codebase to figure it out at this point 😢