topgrade-rs/topgrade v13.0.0 Z4H SSH issue

[lbonvarl]

I am using topgrade on an ARM64 Debian 12 VM via SSH, where Z4H is configured in shell. It seems similar to some issues experienced with other zsh configs:
r-darwish/topgrade#380
r-darwish/topgrade#394

DEBUG Detected "/usr/bin/zsh" as "zsh"
DEBUG Step "antibody"
DEBUG Detected "/usr/bin/zsh" as "zsh"
DEBUG Step "antidote"
DEBUG Detected "/usr/bin/zsh" as "zsh"
DEBUG Step "antigen"
DEBUG Detected "/usr/bin/zsh" as "zsh"
DEBUG Path "/home/loic/.zshrc" exists
DEBUG Step "zgenom"
DEBUG Detected "/usr/bin/zsh" as "zsh"
DEBUG Path "/home/loic/.zshrc" exists
DEBUG Step "zplug"
DEBUG Detected "/usr/bin/zsh" as "zsh"
DEBUG Path "/home/loic/.zshrc" exists
DEBUG Step "zinit"
DEBUG Detected "/usr/bin/zsh" as "zsh"
DEBUG Path "/home/loic/.zshrc" exists
DEBUG Step "zi"
DEBUG Detected "/usr/bin/zsh" as "zsh"
DEBUG Path "/home/loic/.zshrc" exists
DEBUG Step "zim"
DEBUG Detected "/usr/bin/zsh" as "zsh"
DEBUG Executing command `zsh -c '[[ -n ${ZIM_HOME} ]] && print -n ${ZIM_HOME}'`
DEBUG Command failed: Err(
   0: Command failed: `zsh -c '[[ -n ${ZIM_HOME} ]] && print -n ${ZIM_HOME}'`
   1: `zsh` failed: exit status: 1

Location:
   /home/loic/.cargo/registry/src/index.crates.io-6f17d22bba15001f/topgrade-13.0.0/src/steps/zsh.rs:151)
DEBUG Step "oh-my-zsh"
DEBUG Detected "/usr/bin/zsh" as "zsh"
DEBUG Path "/home/loic/.zshrc" exists
DEBUG Executing command `zsh -c 'source /home/loic/.zshrc > /dev/null && export -p | grep ZSH > /dev/null && echo $ZSH'`
DEBUG Command failed: Err(
   0: Command failed: `zsh -c 'source /home/loic/.zshrc > /dev/null && export -p | grep ZSH > /dev/null && echo $ZSH'`

      Stderr:
      /home/loic/.zshrc:56: command not found: z4h
   1: `zsh` failed: exit status: 127

Location:
   /home/loic/.cargo/registry/src/index.crates.io-6f17d22bba15001f/topgrade-13.0.0/src/steps/zsh.rs:190)
DEBUG Step "oh-my-zsh" failed:
   0: Command failed: `zsh -c 'source /home/loic/.zshrc > /dev/null && export -p | grep ZSH > /dev/null && echo $ZSH'`

      Stderr:
      /home/loic/.zshrc:56: command not found: z4h
   1: `zsh` failed: exit status: 127

Location:
   /home/loic/.cargo/registry/src/index.crates.io-6f17d22bba15001f/topgrade-13.0.0/src/steps/zsh.rs:190
oh-my-zsh failed:
   0: Command failed: `zsh -c 'source /home/loic/.zshrc > /dev/null && export -p | grep ZSH > /dev/null && echo $ZSH'`

      Stderr:
      /home/loic/.zshrc:56: command not found: z4h
   1: `zsh` failed: exit status: 127

Location:
   /home/loic/.cargo/registry/src/index.crates.io-6f17d22bba15001f/topgrade-13.0.0/src/steps/zsh.rs:190
Retry? (y)es/(N)o/(s)hell/(q)uit

[romkatv]

If I understand it correctly, this code is running the following command:

zsh -c 'source /home/loic/.zshrc > /dev/null && export -p | grep ZSH > /dev/null && echo $ZSH'

This command is not supposed to work, so sometimes it does not. Try this instead:

zsh -ic 'print -r -- ${ZSH:?}'

This is the whole command that you can use as a substitute for the buggy one.

[lbonvarl]

issue fixed in topgrade-rs/topgrade#647

[romkatv]

Great! Closing.