Skip to content

Commit bc65b00

Browse files
committed
Revert "[cppyy] Skip failing tests in test_datatypes.py"
This reverts commit 65b9ea6.
1 parent 3048154 commit bc65b00

File tree

1 file changed

+16
-18
lines changed

1 file changed

+16
-18
lines changed

bindings/pyroot/cppyy/cppyy/test/test_datatypes.py

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ def test01_instance_data_read_access(self):
192192

193193
c.__destruct__()
194194

195-
@mark.skip()
195+
@mark.xfail()
196196
def test02_instance_data_write_access(self):
197197
"""Test write access to instance public data and verify values"""
198198

@@ -377,7 +377,7 @@ def test03_array_passing(self):
377377

378378
c.__destruct__()
379379

380-
@mark.skip()
380+
@mark.xfail()
381381
def test04_class_read_access(self):
382382
"""Test read access to class public data and verify values"""
383383

@@ -542,7 +542,7 @@ def test06_range_access(self):
542542

543543
c.__destruct__()
544544

545-
@mark.skip()
545+
@mark.xfail()
546546
def test07_type_conversions(self):
547547
"""Test conversions between builtin types"""
548548

@@ -736,7 +736,7 @@ def test10_enum(self):
736736
assert gbl.EnumSpace.AA == 1
737737
assert gbl.EnumSpace.BB == 2
738738

739-
@mark.skip()
739+
@mark.xfail()
740740
def test11_typed_enums(self):
741741
"""Determine correct types of enums"""
742742

@@ -779,7 +779,7 @@ class Test {
779779
assert type(sc.vraioufaux.faux) == bool # no bool as base class
780780
assert isinstance(sc.vraioufaux.faux, bool)
781781

782-
@mark.skip()
782+
@mark.xfail()
783783
def test12_enum_scopes(self):
784784
"""Enum accessibility and scopes"""
785785

@@ -1108,7 +1108,7 @@ def test21_object_validity(self):
11081108

11091109
assert not d2
11101110

1111-
@mark.skip()
1111+
@mark.xfail()
11121112
def test22_buffer_shapes(self):
11131113
"""Correctness of declared buffer shapes"""
11141114

@@ -1277,10 +1277,8 @@ def run(self, f, buf, total):
12771277
if self.has_byte:
12781278
run(self, cppyy.gbl.sum_byte_data, buf, total)
12791279

1280-
# @mark.xfail(run=not IS_MAC_ARM, reason = "Crashes on OS X ARM with" \
1281-
# "libc++abi: terminating due to uncaught exception")
1282-
# Marked as skip to prevent propagation of failure to other tests
1283-
@mark.skip()
1280+
@mark.xfail(run=not IS_MAC_ARM, reason = "Crashes on OS X ARM with" \
1281+
"libc++abi: terminating due to uncaught exception")
12841282
def test26_function_pointers(self):
12851283
"""Function pointer passing"""
12861284

@@ -1562,7 +1560,7 @@ def test30_multi_dim_arrays_of_builtins(test):
15621560
p = (ctype * len(buf)).from_buffer(buf)
15631561
assert [p[j] for j in range(width*height)] == [2*j for j in range(width*height)]
15641562

1565-
@mark.skip()
1563+
@mark.xfail()
15661564
def test31_anonymous_union(self):
15671565
"""Anonymous unions place there fields in the parent scope"""
15681566

@@ -1656,7 +1654,7 @@ def test31_anonymous_union(self):
16561654
assert type(p.data_c[0]) == float
16571655
assert p.intensity == 5.
16581656

1659-
@mark.skip()
1657+
@mark.xfail()
16601658
def test32_anonymous_struct(self):
16611659
"""Anonymous struct creates an unnamed type"""
16621660

@@ -1705,7 +1703,7 @@ class Foo2 {
17051703

17061704
assert 'foo' in dir(ns.libuntitled1_ExportedSymbols().kotlin.root.com.justamouse.kmmdemo)
17071705

1708-
@mark.skip()
1706+
@mark.xfail()
17091707
def test33_pointer_to_array(self):
17101708
"""Usability of pointer to array"""
17111709

@@ -2061,7 +2059,7 @@ def test40_more_aggregates(self):
20612059
r2 = ns.make_R2()
20622060
assert r2.s.x == 1
20632061

2064-
@mark.skip()
2062+
@mark.xfail()
20652063
def test41_complex_numpy_arrays(self):
20662064
"""Usage of complex numpy arrays"""
20672065

@@ -2109,7 +2107,7 @@ def pycompdot(a, b, N):
21092107
Ccl = func(Acl, Bcl, 2)
21102108
assert complex(Ccl) == pyCcl
21112109

2112-
@mark.skip()
2110+
@mark.xfail()
21132111
def test42_mixed_complex_arithmetic(self):
21142112
"""Mixin of Python and C++ std::complex in arithmetic"""
21152113

@@ -2123,7 +2121,7 @@ def test42_mixed_complex_arithmetic(self):
21232121
assert c*(c*c) == p*(p*p)
21242122
assert (c*c)*c == (p*p)*p
21252123

2126-
@mark.skip()
2124+
@mark.xfail()
21272125
def test43_ccharp_memory_handling(self):
21282126
"""cppyy side handled memory of C strings"""
21292127

@@ -2240,7 +2238,7 @@ def test45_const_ref_data(self):
22402238
b = ns.B()
22412239
assert b.body1.name == b.body2.name
22422240

2243-
@mark.skip()
2241+
@mark.xfail()
22442242
def test46_small_int_enums(self):
22452243
"""Proper typing of small int enums"""
22462244

@@ -2295,7 +2293,7 @@ def test46_small_int_enums(self):
22952293
assert ns.func_int8() == -1
22962294
assert ns.func_uint8() == 255
22972295

2298-
@mark.skip()
2296+
@mark.xfail()
22992297
def test47_hidden_name_enum(self):
23002298
"""Usage of hidden name enum"""
23012299

0 commit comments

Comments
 (0)