-
Notifications
You must be signed in to change notification settings - Fork 1.4k
CI: test minimal builds #20311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
CI: test minimal builds #20311
Conversation
51c8112 to
81d472b
Compare
| @@ -0,0 +1,80 @@ | |||
| alien=OFF | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as curiosity, why isn't the config just minimal=ON, without specifying any other build option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good question. In this first approximation, I assumed there was a 'good' reason why those were explicitly off in the usual global.txt and keep all the setting that were OFF or were auxiliary but I may hare erred.
One other reason is that we wanted the options to be explicit rather than implicit and thus for the build to not depend on a change in the source code for the default to change. In the case of minimal this might actually be a detriment.
Test Results 23 files 23 suites 3d 15h 10m 17s ⏱️ For more details on these failures, see this check. Results for commit 41d01fe. |
The ctest for minimal build seems broken again (at least for me) ... adding it to the CI will at least make sure we do not easily break it.