Skip to content

Conversation

@pcanal
Copy link
Member

@pcanal pcanal commented Nov 6, 2025

The ctest for minimal build seems broken again (at least for me) ... adding it to the CI will at least make sure we do not easily break it.

@pcanal pcanal self-assigned this Nov 6, 2025
@pcanal pcanal added the in:CI label Nov 6, 2025
@pcanal pcanal requested a review from dpiparo as a code owner November 6, 2025 19:54
@pcanal pcanal requested review from dpiparo, guitargeek, hageboeck and vepadulano and removed request for dpiparo November 6, 2025 19:54
@pcanal pcanal closed this Nov 6, 2025
@pcanal pcanal reopened this Nov 6, 2025
@pcanal pcanal force-pushed the test-minimal branch 6 times, most recently from 51c8112 to 81d472b Compare November 6, 2025 20:38
@@ -0,0 +1,80 @@
alien=OFF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as curiosity, why isn't the config just minimal=ON, without specifying any other build option?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good question. In this first approximation, I assumed there was a 'good' reason why those were explicitly off in the usual global.txt and keep all the setting that were OFF or were auxiliary but I may hare erred.

One other reason is that we wanted the options to be explicit rather than implicit and thus for the build to not depend on a change in the source code for the default to change. In the case of minimal this might actually be a detriment.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Test Results

    23 files      23 suites   3d 15h 10m 17s ⏱️
 3 707 tests  3 702 ✅ 0 💤 5 ❌
81 993 runs  81 988 ✅ 0 💤 5 ❌

For more details on these failures, see this check.

Results for commit 41d01fe.

@ferdymercury ferdymercury mentioned this pull request Nov 7, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants