fix: handle citation with square brackets better (#79)

Author: maelle

R/translate.R

@@ -407,6 +407,8 @@ protect_squaries <- function(node) {
 
   # https://rstudio.github.io/visual-markdown-editing/citations.html#inserting-citations
   at_things <- regmatches(text, gregexpr("@[[:alnum:]\\-\\_\\:\\.\\#\\$\\%\\&\\-\\+\\?\\<\\>\\~\\/]*", text))[[1]]
+  # https://github.com/ropensci-review-tools/babeldown/issues/78
+  at_things <- sub("</squary><text>", "", at_things)
 
   footnote_things <- regmatches(text, gregexpr("\\^[[:alnum:]]*", text))[[1]]
   text <- purrr::reduce(

tests/testthat/fixtures/example-square2/api/translate-bc12ea-POST.json

@@ -0,0 +1,8 @@
+{
+    "translations": [
+        {
+            "detected_source_language": "EN",
+            "text": "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<!DOCTYPE document SYSTEM \"CommonMark.dtd\">\n<document xmlns=\"http://commonmark.org/xml/1.0\">\n  <paragraph>\n   <text xml:space=\"preserve\">\n     <text xml:space=\"preserve\">Wickham dice bla <\/text>\n     <squary>@wickham24<\/squary>\n     <text>.<\/text>\n   <\/text>\n  <\/paragraph>\n<\/document>\n"
+        }
+    ]
+}

tests/testthat/test-translate.R

@@ -203,6 +203,14 @@ test_that("deepl_translate() handles square brackets stuff well", {
     expect_match(lines, "\\[-@wickham\\+2015\\#]")
     expect_match(lines, "también")
   })
+  with_mock_dir("example-square2", {
+    lines <- deepl_translate_markdown_string(
+      "Wickham says blah [@wickham24].",
+      source_lang = "en",
+      target_lang = "es"
+    )
+    expect_match(lines, "\\[@wickham24]")
+  })
 })
 
 test_that("deepl_translate() handles equations well", {