Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a full URL for roreviewapi debugging endpoints? #24

Open
maelle opened this issue Jan 27, 2022 · 7 comments
Open

Add a full URL for roreviewapi debugging endpoints? #24

maelle opened this issue Jan 27, 2022 · 7 comments

Comments

@maelle
Copy link
Contributor

maelle commented Jan 27, 2022

No description provided.

@mpadge
Copy link
Member

mpadge commented Jan 27, 2022

That would mean exposing the IP address of the Digital Ocean server. It currently has no OAUTH at all, so I'd rather not do that until the whole thing has completely been rebuilt independent of plumber and R (#3), and proper OAUTH implemented (#15).

@maelle
Copy link
Contributor Author

maelle commented Jan 27, 2022

aaah ok makes sense. I actually wondered about that when reading about the delete_cache endpoint.

@mpadge
Copy link
Member

mpadge commented Jan 27, 2022

delete_cache does nothing major - it only means that repeats of the same call are much quicker than the first one; clearing it will only slow things back down again.

@mpadge
Copy link
Member

mpadge commented Jun 28, 2022

This could maybe be addressed after #3 (comment), because that would allow endpoints like these to be password protected.

@maelle
Copy link
Contributor Author

maelle commented Oct 13, 2023

Even with the IP address, I don't know how to access the logs. https://ropensci-review-tools.readthedocs.io/en/latest/maintenance/roreviewapi.html

@maelle
Copy link
Contributor Author

maelle commented Aug 26, 2024

Wondering about this again. Maybe add some practical steps to the readthedocs thing?

@mpadge
Copy link
Member

mpadge commented Aug 26, 2024

Wondering about this again. Maybe add some practical steps to the readthedocs thing?

Done via ropensci-review-tools/ropensci-review-tools#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants