-
Notifications
You must be signed in to change notification settings - Fork 89
Cleanup gmock Test Dependencies #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #460 +/- ##
==========================================
+ Coverage 85.25% 85.33% +0.08%
==========================================
Files 17 17
Lines 1397 1398 +1
Branches 132 132
==========================================
+ Hits 1191 1193 +2
+ Misses 120 119 -1
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
we use gmock per default in all our repositories. I haven't compared it, but the argument of @bmagyar is that the failure messages are more descriptive. |
Interesting... for my own education, what would be an example of this case? My understanding is unless we're making calls to |
|
maybe this was only a decision for simplicity to have the same all over the place, and use gmock matchers where they make sense like |
|
From my experience so far, the issue with defaulting to
I think developers can always include |
Changes
gmocktest deps, when none of the unit tests are usinggmock. This PR updates the dependencies so they'regtestTesting
Notes