check release repository urls are https and have .git extensions

[wjwwood]

Currently when users are prompted for the release repository url on the first release for a distro, they can put what ever they want. If it is github, then we should ensure it is https and .git extended. Other tools in the toolchain should be more robust to this, but I'll enforce it in bloom for consistency.

[dirk-thomas]

Please consider addressing this soon to avoid pull request like this: ros/rosdistro#2990

[mikepurvis]

What's the specific need for .git extension?

[wjwwood]

I forget, @dirk-thomas do you remember? I remember running into this problem before and for some reason the build farm needed the extension or maybe some conditional logic requires it to differentiate something.

[tfoote]

I believe that github is smart enough to to give you what you want, but
many of the standard hosting tools will not differentiate the incoming
client agent and serve the webpage instead of the git repo if you use the
url without .git extension.

[dirk-thomas]

I can't recall the case we had before but we need the .git extension somewhere in the pipeline of the farm I think.

[mikepurvis]

Okay. I'm all for consistency—I just wasn't sure if there was something actually breaking due to it. I'm pretty sure the Clearpath repos are all over the map with respect to including the suffix or not.

Rather than scold users until they get it right, I suggest a regex match -> transform -> confirmation prompt. Eg:

• User pastes in URL which contains "github.com"
• Regex match to extract user/org and repo name
• Create url of form "https://github.com/org/repo.git"
• If URL does not match what was entered, prompt to confirm that this is an okay substitute.

More of an implementation pain, but better end experience, especially for new users of Bloom.

[wjwwood]

I opened #233 to address this. It does not do the more advanced parsing and recommendations that @mikepurvis suggested, but it will check for .git as a suffix and https:// as a prefix, warn if it doesn't have them, and allow them the opportunity to correct the url before continuing.

[wjwwood]

Also adding a rosdistro CI check:

ros/rosdistro#3204

[wjwwood]

This is an example of where the .git extension is expected in our toolchain: ros-infrastructure/rosinstall_generator#18