Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Links to Instance Lists in Dependency table #388

Open
QuentinTorg opened this issue Jun 4, 2024 · 4 comments · May be fixed by #423
Open

Broken Links to Instance Lists in Dependency table #388

QuentinTorg opened this issue Jun 4, 2024 · 4 comments · May be fixed by #423
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@QuentinTorg
Copy link

404 Page URL

https://index.ros.org/packages/rosbag2

Referrer URL

https://index.ros.org/p/ros_base/github-ros2-variants/#jazzy-deps

Description

clicking on the little number next to the dependency names in the left window results in a broken link. The package name itself to the right of this does have a working link

@QuentinTorg QuentinTorg added the bug Something isn't working label Jun 4, 2024
@rkent
Copy link

rkent commented Jun 4, 2024

This is pretty universal, the numbers all seem to have the wrong link.

I believe this comes from:

<a href="{{site.baseurl}}/packages/{{p[0]}}" 

in _includes/package_body.html.

@rkent
Copy link

rkent commented Jun 5, 2024

Why is there a link attached to this number at all? I suppose it might be useful if there are multiple instances of the package. But there is no page that you can go to AFAICT that will show you a list of the package instances.

On the package page, there is a dropdown that shows the list of repository instances for a package. For example, if you go to https://index.ros.org/p/grid_map/#iron and you click on the repo name "GITHUB-ANYBOTICS-GRID_MAP" you get a dropdown showing a list of repo instances for this package. If there is anything useful to link to on the number showing how many instances, this is probably it.

I'm not sure though that there really is much interest in this. It would be easier either to give no link on the number, or simply link to that package (which is already linked in multiple places on the line).

@tfoote
Copy link
Member

tfoote commented Aug 20, 2024

The original intent of the index design was to include indexing of forks. So packages can be found in multiple repositories. For example geometry2 is in 3 different repos:
image

I've been slowly backing this out It looks like this was missed in the cleanup of #281 which is trying to help keep the sight slimmer. The repo specific package pages would be good to clean up too. I think that whole column should now be eliminated.

@tfoote tfoote closed this as completed Aug 20, 2024
@tfoote tfoote changed the title Broken Link:https://index.ros.org/packages/rosbag2 Broken Links to Instance Lists in Dependency table Aug 20, 2024
@tfoote tfoote added the help wanted Extra attention is needed label Aug 20, 2024
@tfoote
Copy link
Member

tfoote commented Aug 20, 2024

Woops, wrong button, reopening

@tfoote tfoote reopened this Aug 20, 2024
tfoote added a commit that referenced this issue Sep 15, 2024
…r down

This fixes #388 

It fixes the broken links by removing them as the extra column's info has been reduced. And while here make it symmetric so you navigate packages both up and down the dependency list.
rkent pushed a commit to rkent/rosindex that referenced this issue Sep 16, 2024
…r down

This fixes ros-infrastructure#388 

It fixes the broken links by removing them as the extra column's info has been reduced. And while here make it symmetric so you navigate packages both up and down the dependency list.
rkent pushed a commit to rkent/rosindex that referenced this issue Sep 17, 2024
…r down

This fixes ros-infrastructure#388 

It fixes the broken links by removing them as the extra column's info has been reduced. And while here make it symmetric so you navigate packages both up and down the dependency list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
3 participants