Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fetching from other sites e.g. gitlab.com #258

Open
shr-project opened this issue Dec 3, 2019 · 4 comments
Open

Support fetching from other sites e.g. gitlab.com #258

shr-project opened this issue Dec 3, 2019 · 4 comments

Comments

@shr-project
Copy link
Contributor

Currently only github.com is supported, but with eloquent the index contains also ros2_tracing components fetched from gitlab.com:
https://gitlab.com/micro-ROS/ros_tracing/ros2_tracing.git
which superflore refuses to generate recipes for.

To generate recipes for eloquent I've worked around this limitation by manually changing the index to use my temporary clone on github.com (https://github.com/shr-project/ros2_tracing) to generate the recipes and then changed the SRC_URI back to gitlab.com.

If we can expect that there will be more components hosted elsewhere, then we should enhance superflore to support that.

@allenh1
Copy link
Contributor

allenh1 commented Dec 3, 2019

Currently only github.com is supported

@shr-project this is because of ros-infrastructure/rosdistro#101.

If we can expect that there will be more components hosted elsewhere, then we should enhance superflore to support that.

There are packages hosted elsewhere, and many of them exist today in ROS 1. This shouldn't be fixed here, though, since it is more of a rosdistro limitation than a superflore limitation.

Once that issue is resolved, I don't believe there's anything that should prevent superflore from generating those recipes (though it will still be unable to push to a non-GitHub repository).

@herb-kuta-lge
Copy link
Contributor

herb-kuta-lge commented Feb 14, 2020

this is because of ros-infrastructure/rosdistro#101.

The pull request for this (ros-infrastructure/rosdistro#102) was closed without merging a year and half ago. Is it ever going to be fixed?

@allenh1
Copy link
Contributor

allenh1 commented Feb 18, 2020

Is it ever going to be fixed?

That's a good question... There's some good discussion on how to proceed, but I haven't had much reason to pursue it lately.

I stopped iterating on it when I saw there was a big difference in approach from my patch, and wanted to just start over on it (though didn't get around to it).

@shr-project
Copy link
Contributor Author

This isn't so important anymore, because ros2_tracing is now fetched from github.com after:
ros/rosdistro@477d7ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants