Errors in windows ci build

[ddengster]

Link to windows ci log
We're using ROS2.

11:48:04 C:\ci\ws\install\include\angles/angles.h(70,43): error C2065: 'M_PI': undeclared identifier (compiling source file C:\ci\ws\src\ros-controls\ros2_controllers\joint_trajectory_controller\src\joint_trajectory_controller.cpp) [C:\ci\ws\build\joint_trajectory_controller\joint_trajectory_controller.vcxproj]

11:48:04 C:\ci\ws\install\include\angles/angles.h(70,47): error C2661: 'fmod': no overloaded function takes 1 arguments (compiling source file C:\ci\ws\src\ros-controls\ros2_controllers\joint_trajectory_controller\src\joint_trajectory_controller.cpp) [C:\ci\ws\build\joint_trajectory_controller\joint_trajectory_controller.vcxproj]

There seem to be several topics about this on stackoverflow

how should we go about fixing this?

[ddengster]

Alright i added a _USE_MATH_DEFINES #define to the cmakelists file and got it fixed

[flynneva]

@ddengster running into the same problem. care to share your solution? I've tried to add it myself following what others have done but it doesnt seem to be working.

[ddengster]

i added the define to the cmakefile

target_compile_definitions(joint_trajectory_controller PRIVATE
  "JOINT_TRAJECTORY_CONTROLLER_BUILDING_DLL" "_USE_MATH_DEFINES")