Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FETCHCONTENT packages using FETCHCONTENT in cmake #1311

Closed
jiaxshi opened this issue Feb 20, 2025 · 2 comments
Closed

Enable FETCHCONTENT packages using FETCHCONTENT in cmake #1311

jiaxshi opened this issue Feb 20, 2025 · 2 comments

Comments

@jiaxshi
Copy link
Contributor

jiaxshi commented Feb 20, 2025

Backgrould:
Many ROS xxx-vendor packages download source code via FETCHCONTENT in cmake process. But FETCHCONTENT is disabled by default in yocto.

    -DFETCHCONTENT_FULLY_DISCONNECTED=ON \

In some recipes of meta-ros, reset SRC and revision to download source code with bitbake. Then we need to manually check and update revision/version of these packages. Or we will encounter mismatch problems, such as #1310 .

I propose to use EXTRA_OECMAKE:append = " -DFETCHCONTENT_FULLY_DISCONNECTED=OFF" in all the bbappends, then we don't need to maintain SRC and revision.

@vermaete
Copy link
Contributor

I would not do this.

Some people using Yocto and ROS are working in air gapped networks. To useful stuff in Yocto to handle this will not work when allowing fetching of code after the do_fetch.
Another reason is that reproducible builds become difficult when code is fetched during do_compile instead of do_fetch.

Br

@robwoolley
Copy link
Collaborator

Thanks for highlighting this @jiaxshi. As @vermaete said, we need to support an airgap environment, particularly for people that want to be able to maintain a particular release past its end-of-life date. This did help point out a mistake that I made in duplicating the SRCREV in the bbappend. I did this because of recent changes to how AUTOREV works, however I should have just done: SRCREV_foobar = "${SRCREV}" I made this change in mcap and 1 or 2 other packages. It should ease the burden going forward.

@jiaxshi jiaxshi closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants