Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider exposing urdfdom_headers version in a header file #30

Open
jslee02 opened this issue Aug 27, 2016 · 0 comments
Open

Consider exposing urdfdom_headers version in a header file #30

jslee02 opened this issue Aug 27, 2016 · 0 comments

Comments

@jslee02
Copy link
Contributor

jslee02 commented Aug 27, 2016

It seems the API changes introduced by version 1.0 are relatively small; switching to use C++11 instead of boost. If so, consumer libraries (like DART) could support for version 1.0 and other lesser versions with some preprocessors depending on the versions.

One issue of doing this is that urdfdom_headers doesn't expose the version numbers in the header files so that consumer libraries have to extract the version numbers from CMake variables. I propose exposing urdfdom_headers version in a header file, or it would nicer if anyone knows better way to get the version numbers in consumer libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants