add QoS Profile/Depth support to Node. #1376
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujitatomoya
requested review from
sloretz and
adityapande-1995
as code owners
fujitatomoya
commented
Nov 3, 2024
|
@ahcorde @clalancette please take a look if you have time. |
ahcorde
requested changes
Nov 4, 2024
There was a problem hiding this comment.
flake8 is failing https://build.ros2.org/job/Rpr__rclpy__ubuntu_noble_amd64/400/
|
Pulls: #1376
|
clalancette
requested changes
Nov 4, 2024
|
@clalancette thanks for the review and information. i agree with your comments, i will try to address them. |
Signed-off-by: Tomoya Fujita <[email protected]>
Signed-off-by: Tomoya Fujita <[email protected]>
Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya
force-pushed
the
fujitatomoya/node-rosout-qos-profile-support
branch
from
987bc36
to
1e5a670
Compare
Signed-off-by: Tomoya Fujita <[email protected]>
|
@clalancette this is ready to review. to expose default rosout qos profile to rclpy, it requires the following changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1368
depends on ros2/rmw#381