Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rosbag2_py] Typo in Recorder's signal restoration? (second SIGTERM should be SIGINT) #1686

Closed
EricCousineau-TRI opened this issue Jun 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@EricCousineau-TRI
Copy link

Description

Per comment in
#1678 (comment)
Line 239 should be SIGINT, not SIGTERM:

// Return old signal handlers anyway
if (old_sigterm_handler != SIG_ERR) {
std::signal(SIGTERM, old_sigterm_handler);
}
if (old_sigint_handler != SIG_ERR) {
std::signal(SIGTERM, old_sigint_handler);
}

fyi @MichaelOrlov

Expected Behavior

Line 239 should be SIGINT, not SIGTERM

Actual Behavior

It is SIGTERM

To Reproduce

See code.

System (please complete the following information)

  • OS: Any
  • ROS 2 Distro: Humble
  • Install Method: Any
  • Version: humble

Additional context

Relates #1678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants