Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python SequentialReader does not bind close method #1934

Closed
oysstu opened this issue Mar 7, 2025 · 3 comments
Closed

Python SequentialReader does not bind close method #1934

oysstu opened this issue Mar 7, 2025 · 3 comments

Comments

@oysstu
Copy link
Contributor

oysstu commented Mar 7, 2025

pybind11::class_<PyReader>(m, "SequentialReader")

Intended to open and close a bag in the __enter__ and __exit__ methods of a class, and noticed that the close() function is not exposed through pybind11.

@yassine-cherni
Copy link

you should add a .def("close", &PyReader::close)

@christophebedard
Copy link
Member

Yeah, exposing the close() methods makes sense.

@oysstu
Copy link
Contributor Author

oysstu commented Mar 12, 2025

Fixed in #1935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants