errourCount shows the real count of errors

rrd108 · Feb 28, 2022 · 21e23f3 · 21e23f3
1 parent eaf1eb9
commit 21e23f3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/Error/JsonApiExceptionRenderer.php b/src/Error/JsonApiExceptionRenderer.php
@@ -10,13 +10,21 @@ class JsonApiExceptionRenderer extends ExceptionRenderer
 {
     public function jsonApi(JsonApiException $error)
     {
+        $errors = $error->getRequestErrors();
+        $errorsCount = 0;
+        foreach ($errors as $err) {
+            if (count($err)) {
+                $errorsCount++;
+            }
+        }
+
         $response = $this->controller->getResponse();
         $data = [
             'message' => $error->getMessage(),
             'url' =>  $this->controller->getRequest()->getRequestTarget(),
             'line' => $error->getLine(),
-            'errorCount' => count(Hash::flatten($error->getRequestErrors())),
-            'errors' => $error->getRequestErrors(),
+            'errorCount' => $errorsCount,
+            'errors' => $errors,
         ];
 
         return $response

diff --git a/tests/TestCase/JsonApiExceptionRendererTest.php b/tests/TestCase/JsonApiExceptionRendererTest.php
@@ -42,7 +42,8 @@ public function testJsonApiWithEntitiesError()
         $firstEntity->setError('name', ['_empty' => $this->validationError]);
         $secondEntity = new Entity();
         $secondEntity->setError('name', ['_empty' => $this->validationError]);
-        $entities = [$firstEntity, $secondEntity];
+        $thirdEntity = new Entity();
+        $entities = [$firstEntity, $secondEntity, $thirdEntity];
         $exception = new JsonApiException($entities, $this->message);
 
         $request = (new ServerRequest())