Error found in new rsk3.Contract(abi)

[chrisli30]

I found an error with test: eth_sendRawTransaction. This error is related to the creation of a contract, the line with the problem is let contract = new rsk3.Contract(abi).

I created a new repo with this, you can check it here: https://github.com/jonathansmirnoff/json-rpc-web3js/tree/smoke-test-migration. You can pull it and run. So it should be easy to know where the problem is. Also if you need some help to fix it, please let me know.

[huhu2356]

error is orginal from rsk3-utils package keccak256 method;

i see repo use "rsk3": "^0.2.0" the code is old;
so the repo keccak256 method code is

var keccak256 = function keccak256(value) {
  if (isHexStrict(value) && /^0x/i.test(value.toString())) {
    value = hexToBytes(value);
  } else {
     throw new Error('value parameter should be a hex string.');
  }
  var returnValue = Hash.keccak256(value);
  if (returnValue === KECCAK256_NULL_S) {
    return null;
  } else {
    return returnValue;
  }
};

tht error is from the line

else {
     throw new Error('value parameter should be a hex string.');
}

i look now rsk3 repo master branch, this line is deleted;

 throw new Error('value parameter should be a hex string.');

the keccak256 method is now

const keccak256 = (value) => {
    if (!isString(value) && !isNumber(value)) {
        throw new Error('value parameter should be a number or string.');
    }

    if (isHexStrict(value) && /^0x/i.test(value.toString())) {
        value = hexToBytes(value);
    }

    const returnValue = Hash.keccak256(value); // jshint ignore:line

    if (returnValue === KECCAK256_NULL_S) {
        return null;
    } else {
        return returnValue;
    }
};

so if use latest code from rsk3, this error will not appear;