Skip to content

Commit 9ba4f89

Browse files
authored
Merge pull request #2866 from rspec/fix-rails-main
Update specs for rails main
2 parents 2371f28 + 9781027 commit 9ba4f89

File tree

3 files changed

+28
-3
lines changed

3 files changed

+28
-3
lines changed

lib/generators/rspec/scaffold/templates/index_spec.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,11 @@
1818
1919
it "renders a list of <%= ns_table_name %>" do
2020
render
21+
<% if Rails.version.to_f < 8.1 -%>
2122
cell_selector = 'div>p'
23+
<% else -%>
24+
cell_selector = 'div>div>div'
25+
<% end -%>
2226
<% for attribute in output_attributes -%>
2327
assert_select cell_selector, text: Regexp.new(<%= value_for(attribute) %>.to_s), count: 2
2428
<% end -%>

spec/generators/rspec/scaffold/scaffold_generator_spec.rb

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,14 @@
264264
.and(contain(/assign\(:posts, /))
265265
.and(contain(/it "renders a list of (.*)"/))
266266

267-
expect(filename).to contain(/'div>p'/)
267+
selector =
268+
if Rails.version.to_f < 8.1
269+
/'div>p'/
270+
else
271+
/'div>div>div'/
272+
end
273+
274+
expect(filename).to contain(selector)
268275
end
269276
end
270277

spec/rspec/rails/matchers/action_cable/have_stream_spec.rb

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,16 @@ def subscribed
158158
it "fails with message" do
159159
subscribe user: 42
160160

161+
broadcast_preamble =
162+
if Rails.version.to_f < 8.1
163+
"broadcast:StreamModel#"
164+
else
165+
"broadcast:"
166+
end
167+
161168
expect {
162169
expect(subscription).to have_stream_for(StreamModel.new(31_337))
163-
}.to raise_error(/expected to have stream "broadcast:StreamModel#31337" started, but have \["broadcast:StreamModel#42"\]/)
170+
}.to raise_error(/expected to have stream "#{broadcast_preamble}31337" started, but have \["#{broadcast_preamble}42"\]/)
164171
end
165172

166173
context "with negated form" do
@@ -173,9 +180,16 @@ def subscribed
173180
it "fails with message" do
174181
subscribe user: 42
175182

183+
broadcast_id =
184+
if Rails.version.to_f < 8.1
185+
"broadcast:StreamModel#42"
186+
else
187+
"broadcast:42"
188+
end
189+
176190
expect {
177191
expect(subscription).not_to have_stream_for(StreamModel.new(42))
178-
}.to raise_error(/expected not to have stream "broadcast:StreamModel#42" started, but have \["broadcast:StreamModel#42"\]/)
192+
}.to raise_error(/expected not to have stream "#{broadcast_id}" started, but have \["#{broadcast_id}"\]/)
179193
end
180194
end
181195
end

0 commit comments

Comments
 (0)