-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should be able to pass empty results to a tag and have it stay on same line. #13
Comments
Hey there, sorry there isn't any! There are newlines going to be inserted; This feature was never planned in Expug, unfortunately. |
if you point me at the right spot i would attempt a PR
On Jul 26, 2019, at 2:38 AM, Rico Sta. Cruz <[email protected]> wrote:
Hey there, sorry there isn't any! There are newlines going to be inserted; p= xyz will translate to <p><%= "\n" %><%= xyz %><%= "\n" %></p>.
This feature was never planned in Expug, unfortunately.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Oh cool, this issue's still open. It's disappointing to hear this isn't considered a bug, and won't be fixed being that it was not a planned feature. It implies having to either accept visual artifacts on an expug-rendered page when no data is available for a given variable or function return, or having to incorporate kludgy As an example of what I mean, this is the standard Phoenix Framework The blue and red boxes are info and error alert boxes, rendering because no text is returned via the main.container(role="main")
= if get_flash(@conn, :info) do
p.alert.alert-info(role="alert")= get_flash(@conn, :info)
= if get_flash(@conn, :error) do
p.alert.alert-danger(role="alert")= get_flash(@conn, :error) Simple as this was to do for this one top-level layout template, it is a brittle coding pattern overall, and I can imagine similar visual artifacts ending up on larger websites because of the need to implement the I'm hoping this doesn't become a showstopper in building my app using Expug for my template files. The syntax is refreshingly terse compared to |
Annnd I reverted to The good news is, I'm sure it'll circle back to hilarious in due time |
this seems like it wouldn't be an expensive PR. I'm open to submitting one, but I'd like a pointer for which section of code would be the right spot to start. |
I've just decided to use Slime instead |
Unfortunately I can't maintain this library anymore. If anyone would like
to take over, let me know and I can transfer it.
…On Fri, 22 Jan 2021, 12:25 pm thepeoplesbourgeois, ***@***.***> wrote:
I've just decided to use Slime <https://github.com/slime-lang/slime>
instead
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#13 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAASFEMRZMDRMNFCAOJJSKDS3DHYPANCNFSM4GDTDOPQ>
.
|
consider:
I would expect
instead i get
...which seems wrong. Is there a mode to turn off the unintended newlines?
The text was updated successfully, but these errors were encountered: