Suppress warnings in specs rather than global filtering in MSpec

Author: eregon

core/argf/bytes_spec.rb

@@ -3,6 +3,14 @@
 
 ruby_version_is ''...'3.0' do
   describe "ARGF.bytes" do
+    before :each do
+      @verbose, $VERBOSE = $VERBOSE, nil
+    end
+
+    after :each do
+      $VERBOSE = @verbose
+    end
+
     it_behaves_like :argf_each_byte, :bytes
   end
 end

core/argf/chars_spec.rb

@@ -3,6 +3,14 @@
 
 ruby_version_is ''...'3.0' do
   describe "ARGF.chars" do
+    before :each do
+      @verbose, $VERBOSE = $VERBOSE, nil
+    end
+
+    after :each do
+      $VERBOSE = @verbose
+    end
+
     it_behaves_like :argf_each_char, :chars
   end
 end

core/argf/codepoints_spec.rb

@@ -3,6 +3,14 @@
 
 ruby_version_is ''...'3.0' do
   describe "ARGF.codepoints" do
+    before :each do
+      @verbose, $VERBOSE = $VERBOSE, nil
+    end
+
+    after :each do
+      $VERBOSE = @verbose
+    end
+
     it_behaves_like :argf_each_codepoint, :codepoints
   end
 end

core/argf/lines_spec.rb

@@ -3,6 +3,14 @@
 
 ruby_version_is ''...'3.0' do
   describe "ARGF.lines" do
+    before :each do
+      @verbose, $VERBOSE = $VERBOSE, nil
+    end
+
+    after :each do
+      $VERBOSE = @verbose
+    end
+
     it_behaves_like :argf_each_line, :lines
   end
 end

core/enumerator/initialize_spec.rb

@@ -13,7 +13,9 @@
 
   ruby_version_is ''...'3.0' do
     it "returns self when given an object" do
-      @uninitialized.send(:initialize, Object.new).should equal(@uninitialized)
+      suppress_warning do
+        @uninitialized.send(:initialize, Object.new).should equal(@uninitialized)
+      end
     end
   end
 

core/enumerator/new_spec.rb

@@ -10,25 +10,26 @@
 
     ruby_version_is ''...'3.0' do
       it "creates a new custom enumerator with the given object, iterator and arguments" do
-        enum = Enumerator.new(1, :upto, 3)
+        enum = suppress_warning { Enumerator.new(1, :upto, 3) }
         enum.should be_an_instance_of(Enumerator)
       end
 
       it "creates a new custom enumerator that responds to #each" do
-        enum = Enumerator.new(1, :upto, 3)
+        enum = suppress_warning { Enumerator.new(1, :upto, 3) }
         enum.respond_to?(:each).should == true
       end
 
       it "creates a new custom enumerator that runs correctly" do
-        Enumerator.new(1, :upto, 3).map{|x|x}.should == [1,2,3]
+        suppress_warning { Enumerator.new(1, :upto, 3) }.map{ |x| x }.should == [1,2,3]
       end
 
       it "aliases the second argument to :each" do
-        Enumerator.new(1..2).to_a.should == Enumerator.new(1..2, :each).to_a
+        suppress_warning { Enumerator.new(1..2) }.to_a.should ==
+          suppress_warning { Enumerator.new(1..2, :each) }.to_a
       end
 
       it "doesn't check for the presence of the iterator method" do
-        Enumerator.new(nil).should be_an_instance_of(Enumerator)
+        suppress_warning { Enumerator.new(nil) }.should be_an_instance_of(Enumerator)
       end
 
       it "uses the latest define iterator method" do
@@ -37,7 +38,7 @@ def each
             yield :foo
           end
         end
-        enum = Enumerator.new(StrangeEach.new)
+        enum = suppress_warning { Enumerator.new(StrangeEach.new) }
         enum.to_a.should == [:foo]
         class StrangeEach
           def each

core/hash/shared/index.rb

@@ -3,25 +3,35 @@
 
 describe :hash_index, shared: true do
   it "returns the corresponding key for value" do
-    { 2 => 'a', 1 => 'b' }.send(@method, 'b').should == 1
+    suppress_warning do # for Hash#index
+      { 2 => 'a', 1 => 'b' }.send(@method, 'b').should == 1
+    end
   end
 
   it "returns nil if the value is not found" do
-    { a: -1, b: 3.14, c: 2.718 }.send(@method, 1).should be_nil
+    suppress_warning do # for Hash#index
+      { a: -1, b: 3.14, c: 2.718 }.send(@method, 1).should be_nil
+    end
   end
 
   it "doesn't return default value if the value is not found" do
-    Hash.new(5).send(@method, 5).should be_nil
+    suppress_warning do # for Hash#index
+      Hash.new(5).send(@method, 5).should be_nil
+    end
   end
 
   it "compares values using ==" do
-    { 1 => 0 }.send(@method, 0.0).should == 1
-    { 1 => 0.0 }.send(@method, 0).should == 1
+    suppress_warning do # for Hash#index
+      { 1 => 0 }.send(@method, 0.0).should == 1
+      { 1 => 0.0 }.send(@method, 0).should == 1
+    end
 
     needle = mock('needle')
     inhash = mock('inhash')
     inhash.should_receive(:==).with(needle).and_return(true)
 
-    { 1 => inhash }.send(@method, needle).should == 1
+    suppress_warning do # for Hash#index
+      { 1 => inhash }.send(@method, needle).should == 1
+    end
   end
 end

core/integer/shared/exponent.rb

@@ -47,7 +47,9 @@
     end
 
     it "returns Float::INFINITY when the number is too big" do
-      2.send(@method, 427387904).should == Float::INFINITY
+      -> {
+        2.send(@method, 427387904).should == Float::INFINITY
+      }.should complain(/warning: in a\*\*b, b may be too big/)
     end
 
     it "raises a ZeroDivisionError for 0 ** -1" do
@@ -105,7 +107,10 @@
     end
 
     it "switch to a Float when the values is too big" do
-      flt = @bignum.send(@method, @bignum)
+      flt = nil
+      -> {
+        flt = @bignum.send(@method, @bignum)
+      }.should complain(/warning: in a\*\*b, b may be too big/)
       flt.should be_kind_of(Float)
       flt.infinite?.should == 1
     end

core/io/bytes_spec.rb

@@ -6,9 +6,11 @@
   describe "IO#bytes" do
     before :each do
       @io = IOSpecs.io_fixture "lines.txt"
+      @verbose, $VERBOSE = $VERBOSE, nil
     end
 
     after :each do
+      $VERBOSE = @verbose
       @io.close unless @io.closed?
     end
 

core/io/chars_spec.rb

@@ -5,10 +5,26 @@
 
 ruby_version_is ''...'3.0' do
   describe "IO#chars" do
+    before :each do
+      @verbose, $VERBOSE = $VERBOSE, nil
+    end
+
+    after :each do
+      $VERBOSE = @verbose
+    end
+
     it_behaves_like :io_chars, :chars
   end
 
   describe "IO#chars" do
+    before :each do
+      @verbose, $VERBOSE = $VERBOSE, nil
+    end
+
+    after :each do
+      $VERBOSE = @verbose
+    end
+
     it_behaves_like :io_chars_empty, :chars
   end
 end

core/io/codepoints_spec.rb

@@ -6,15 +6,25 @@
 
   # See redmine #1667
   describe "IO#codepoints" do
+    before :each do
+      @verbose, $VERBOSE = $VERBOSE, nil
+    end
+
+    after :each do
+      $VERBOSE = @verbose
+    end
+
     it_behaves_like :io_codepoints, :codepoints
   end
 
   describe "IO#codepoints" do
     before :each do
       @io = IOSpecs.io_fixture "lines.txt"
+      @verbose, $VERBOSE = $VERBOSE, nil
     end
 
     after :each do
+      $VERBOSE = @verbose
       @io.close unless @io.closed?
     end
 

core/io/lines_spec.rb

@@ -6,9 +6,11 @@
   describe "IO#lines" do
     before :each do
       @io = IOSpecs.io_fixture "lines.txt"
+      @verbose, $VERBOSE = $VERBOSE, nil
     end
 
     after :each do
+      $VERBOSE = @verbose
       @io.close if @io
     end
 

language/pattern_matching_spec.rb

@@ -5,7 +5,7 @@
     # TODO: Remove excessive eval calls when support of previous version
     #       Ruby 2.6 will be dropped
 
-    before do
+    before :each do
       ScratchPad.record []
     end
 
@@ -41,14 +41,20 @@
     end
 
     describe "warning" do
-      before do
+      before :each do
         ruby_version_is ""..."3.0" do
           @src = 'case [0, 1]; in [a, b]; end'
         end
 
         ruby_version_is "3.0" do
           @src = '[0, 1] => [a, b]'
         end
+
+        @experimental, Warning[:experimental] = Warning[:experimental], true
+      end
+
+      after :each do
+        Warning[:experimental] = @experimental
       end
 
       it "warns about pattern matching is experimental feature" do

library/stringio/bytes_spec.rb

@@ -4,10 +4,26 @@
 
 ruby_version_is ''...'3.0' do
   describe "StringIO#bytes" do
+    before :each do
+      @verbose, $VERBOSE = $VERBOSE, nil
+    end
+
+    after :each do
+      $VERBOSE = @verbose
+    end
+
     it_behaves_like :stringio_each_byte, :bytes
   end
 
   describe "StringIO#bytes when self is not readable" do
+    before :each do
+      @verbose, $VERBOSE = $VERBOSE, nil
+    end
+
+    after :each do
+      $VERBOSE = @verbose
+    end
+
     it_behaves_like :stringio_each_byte_not_readable, :bytes
   end
 end

library/stringio/chars_spec.rb

@@ -4,10 +4,26 @@
 
 ruby_version_is ''...'3.0' do
   describe "StringIO#chars" do
+    before :each do
+      @verbose, $VERBOSE = $VERBOSE, nil
+    end
+
+    after :each do
+      $VERBOSE = @verbose
+    end
+
     it_behaves_like :stringio_each_char, :chars
   end
 
   describe "StringIO#chars when self is not readable" do
+    before :each do
+      @verbose, $VERBOSE = $VERBOSE, nil
+    end
+
+    after :each do
+      $VERBOSE = @verbose
+    end
+
     it_behaves_like :stringio_each_char_not_readable, :chars
   end
 end

library/stringio/codepoints_spec.rb

@@ -4,9 +4,16 @@
 require_relative 'shared/codepoints'
 
 ruby_version_is ''...'3.0' do
-
   # See redmine #1667
   describe "StringIO#codepoints" do
+    before :each do
+      @verbose, $VERBOSE = $VERBOSE, nil
+    end
+
+    after :each do
+      $VERBOSE = @verbose
+    end
+
     it_behaves_like :stringio_codepoints, :codepoints
   end
 end