Skip to content

Explicitly return thread interrupt state in zstream_run_func #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Explicitly return thread interrupt state in zstream_run_func #74

wants to merge 3 commits into from
+47 −2

Conversation

ianks
Copy link

@ianks ianks commented Jan 11, 2024

Previously, there were race conditions checking the interrupt flag when checking whether to retry zstream_run_func. Instead of relying on the volatile args->interrupt state, we now explicitly signal the function returned due to an interrupt so it can be retried safely.

fixes #57

This was referenced Jan 13, 2024
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thread#wakeup leads to Zlib::BufError
1 participant
@ianks