Remove automatic resizing from Ferrum

This should really live at the Cuprite level, emulating specific
devices.

Author: duncan-bayne

lib/ferrum/page.rb

@@ -138,10 +138,6 @@ def close_connection
     #
     # Overrides device screen dimensions and emulates viewport according to parameters.
     #
-    # Note that passing mobile: true will cause set_viewport to ignore the passed
-    # height and width values, and instead use 390 x 844, which is the viewport size
-    # of an iPhone 14.
-    #
     # Read more [here](https://chromedevtools.github.io/devtools-protocol/tot/Emulation/#method-setDeviceMetricsOverride).
     #
     # @param [Integer] width width value in pixels. 0 disables the override
@@ -159,37 +155,24 @@ def set_viewport(width:, height:, scale_factor: 0, mobile: false)
           enabled: true,
           maxTouchPoints: 1
         )
-
-        command(
-          "Emulation.setDeviceMetricsOverride",
-          deviceScaleFactor: 3.0,
-          height: 844,
-          mobile: true,
-          slowmoable: true,
-          width: 390
-        )
       else
         command(
           "Emulation.setTouchEmulationEnabled",
           enabled: false
         )
-
-        command(
-          "Emulation.setDeviceMetricsOverride",
-          deviceScaleFactor: scale_factor,
-          height: height,
-          mobile: false,
-          slowmoable: true,
-          width: width
-        )
       end
+
+      command(
+        "Emulation.setDeviceMetricsOverride",
+        deviceScaleFactor: scale_factor,
+        height: height,
+        mobile: true,
+        slowmoable: true,
+        width: width
+      )
     end
 
     def resize(width: nil, height: nil, fullscreen: false, mobile: false)
-      if mobile && (height != 0 || width != 0)
-        raise "specifying `mobile: true` causes automatic resizing to mobile dimensions"
-      end
-
       if fullscreen
         width, height = document_size
         self.window_bounds = { window_state: "fullscreen" }

spec/page_spec.rb

@@ -188,15 +188,6 @@
     end
   end
 
-  describe "#set_viewport" do
-    it "overrides the viewport size" do
-      page.set_viewport(width: 500, height: 300, scale_factor: 2)
-
-      expect(page.viewport_size).to eq([500, 300])
-      expect(page.device_pixel_ratio).to eq(2)
-    end
-  end
-
   describe "#on" do
     it "subscribes to an event" do
       message = nil
@@ -277,29 +268,6 @@ def is_mobile?
           page.reload
         end.to change { is_mobile? }.to(true)
       end
-
-      it "resizes to the size of an iPhone 14 viewport, taking into account scale factor" do
-        expect do
-          page.resize(width: 0, height: 0, mobile: true)
-          page.reload
-        end.to change { body_size }.to(width: 980, height: 2120)
-      end
-
-      context "when a height is passed" do
-        it "raises an error" do
-          expect do
-            page.resize(width: 0, height: 100, mobile: true)
-          end.to raise_error("specifying `mobile: true` causes automatic resizing to mobile dimensions")
-        end
-      end
-
-      context "when a width is passed" do
-        it "raises an error" do
-          expect do
-            page.resize(width: 100, height: 0, mobile: true)
-          end.to raise_error("specifying `mobile: true` causes automatic resizing to mobile dimensions")
-        end
-      end
     end
   end
 end