Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PACKS] #13 Calcuate Product Totals #4408

Open
2 tasks
cielf opened this issue May 30, 2024 · 3 comments · May be fixed by #4609
Open
2 tasks

[PACKS] #13 Calcuate Product Totals #4408

cielf opened this issue May 30, 2024 · 3 comments · May be fixed by #4609

Comments

@cielf
Copy link
Collaborator

cielf commented May 30, 2024

Summary

Update Calculate Product Totals to include packs

Why

This is step #13 of adding the ability to specify "packs" versus "individual" for requests

Details

"Calculate Product Totals" on the Bank's request index (left hand menu Requests) currently products a list of the items that are in the outstanding requests, with a total of the number of each item needed.

(/requests#calcluateTotals)

Instead of having one line per item, we will need to provide one line per item/unit combintation.

So, if we have both requests for units and for custom units, there will be multiple lines for the item. The custom request unit will be included in the Quantity Column.

Let's also make the list alpabetical by item name, with # of items for the "normal" units first, and then any with the packs.

Visual Aid

Image

N.B.

All of the changes for PACKS must be implemented behind a flipper flag "enable_packs"

1/ Flipper works by enabling or disabling a tag (for the PACKS issues, that is enable_packs)
2/ Here is a code snippet illustrating how to use it in your code, with enable_packs as the example tag:
if Flipper.enabled?(:enable_packs)
// do the thing we are guarding with the tag
end
3/ How to check out if it works manually (with the example tag: enable_packs ):
You have to enable the flipper tag on your localhost (note - the tag is stored in your db, so if you reset your db you have to do it again)

localhost:3000/flipper

userid: admin
password: password
Sign In

Click: Add feature
enable_packs
Click: Add feature

Click: Fully enable

To set it back (to check that your nifty changes haven’t broken anything when the flag is off)
Sign in as above:
click on “enable_packs”
click “Delete”
type enable_packs in the “Are you sure” dialog and click ok

Criteria for completion

  • functionality as described above
  • tests that support the functionality as described above

Background

The following sections have been identified as required for the PACKS implementation. These should be implemented in numerical order. This particular one was a late-found change, and so isn't in the diagram below.

Image

@cielf cielf added the Ruby for Good 2024 DC Issues for RFG 2024 DC label May 30, 2024
@awwaiid awwaiid added this to the Packs milestone May 31, 2024
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Intermediate and removed Ruby for Good 2024 DC Issues for RFG 2024 DC labels Jul 7, 2024
@awwaiid awwaiid self-assigned this Aug 24, 2024
@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Aug 24, 2024
@awwaiid awwaiid linked a pull request Aug 25, 2024 that will close this issue
@awwaiid awwaiid linked a pull request Aug 25, 2024 that will close this issue
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Sep 24, 2024
@cielf cielf removed the stale label Sep 24, 2024
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Automatically unassigned after 7 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants