Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quota on partner should be restricted to non-negative. #4657

Closed
2 tasks
cielf opened this issue Sep 15, 2024 · 3 comments · Fixed by #4658
Closed
2 tasks

quota on partner should be restricted to non-negative. #4657

cielf opened this issue Sep 15, 2024 · 3 comments · Fixed by #4658
Assignees
@italomatos

Comments

@cielf
Copy link
Collaborator

cielf commented Sep 15, 2024

Summary

The quota on partners should be restricted to non-negative

Why?

Any negative number would be an obvious mistake, as this is the number of items they can request per request.

Details

Recreation

login in as [email protected]
From the left hand menu: Partner Agencies | All Partners
click on a Partner, then on "Edit Partner Information"
Enter a negative number in quota, then "Update Partner".
It saves.
It should, instead give an error message indicating that the quota has to be at least 0.

Criteria for completion

  • behaviour as above
  • tests to support above behaviour
@italomatos
Copy link
Contributor

hey @cielf can I do this?

@italomatos italomatos mentioned this issue Sep 15, 2024
Merged
@cielf
Copy link
Collaborator Author

cielf commented Sep 15, 2024

Go ahead.

@italomatos
Copy link
Contributor

#4658

🚀🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@italomatos italomatos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add restriction non negative partner quota italomatos/human-essentials
2 participants
@italomatos @cielf