Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DefaultPetTask to Checklist::TaskTemplate #834

Open
kasugaijin opened this issue Jun 12, 2024 · 8 comments
Open

Rename DefaultPetTask to Checklist::TaskTemplate #834

kasugaijin opened this issue Jun 12, 2024 · 8 comments

Comments

@kasugaijin
Copy link
Collaborator

DefaultPetTask should be renamed to Checklist::TaskTemplate. This means renaming all areas in the app (table (default_pet_tasks), model, controller, policies, views, tests, variables, methods etc.). It should be a relatively straightforward find and replace.

Note the table should be renamed to task_templates_table. The Checklist scope helps to organize this resource along with others that are similar.

please nest the classes instead of inline: https://thoughtbot.com/blog/why-you-should-nest-modules-in-ruby we are trying to move to the nested format throughout.

Any questions - comment below!

@kasugaijin kasugaijin added the Ready Make a comment to get assigned. label Jun 12, 2024
@ErinClaudio
Copy link
Collaborator

ErinClaudio commented Jun 12, 2024

@kasugaijin can I take this one?

@ErinClaudio ErinClaudio self-assigned this Jun 12, 2024
@kasugaijin kasugaijin removed the Ready Make a comment to get assigned. label Jun 12, 2024
@kasugaijin
Copy link
Collaborator Author

kasugaijin commented Jun 12, 2024

@ErinClaudio all yours

@ErinClaudio
Copy link
Collaborator

@ben @mononoken I have a couple of things that are going to keep me busy and unable to work on this until Wednesday. I am happy to start this then but I do not want to block anyone else's work. please feel free to give this away if needed

@kasugaijin kasugaijin added the Ready Make a comment to get assigned. label Jun 14, 2024
@kasugaijin
Copy link
Collaborator Author

OK, I will unassign now and if it's free on Wed pick it up! @ErinClaudio

@ErinClaudio
Copy link
Collaborator

Ok - I can do this one now @kasugaijin

@ErinClaudio ErinClaudio self-assigned this Jun 25, 2024
@ErinClaudio
Copy link
Collaborator

@kasugaijin kasugaijin removed the Ready Make a comment to get assigned. label Jun 26, 2024
Copy link

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link

github-actions bot commented Aug 3, 2024

Automatically unassigned after 7 days of inactivity.

@github-actions github-actions bot removed the Stale label Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants