Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Task to Checklist::TaskAssignment #839

Open
kasugaijin opened this issue Jun 15, 2024 · 6 comments
Open

Rename Task to Checklist::TaskAssignment #839

kasugaijin opened this issue Jun 15, 2024 · 6 comments
Labels
on hold Further investigation/decision-making is required

Comments

@kasugaijin
Copy link
Collaborator

Task should be renamed to Checklist::TaskAssignment. This means renaming all areas in the app (table (tasks), model, controller, policies, views, tests, variables, methods etc.). It should be a relatively straightforward find and replace.

Note the table should be renamed to task_assignments_table. The Checklist scope helps to organize this resource along with others that are similar.

please nest the classes instead of inline: https://thoughtbot.com/blog/why-you-should-nest-modules-in-ruby we are trying to move to the nested format throughout.

Any questions - comment below!

@kasugaijin kasugaijin added the Ready Make a comment to get assigned. label Jun 15, 2024
@wandergithub
Copy link
Contributor

Can I work on this?

@kasugaijin
Copy link
Collaborator Author

@wandergithub yup!

@kasugaijin kasugaijin removed the Ready Make a comment to get assigned. label Jun 15, 2024
Copy link

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the Stale label Jul 16, 2024
@kasugaijin
Copy link
Collaborator Author

@wandergithub it looks like this has sat for a while, which is fine. We decided we are going to go to MVP using the existing Default Pet Task model and Task model, so this issue can actually sit until later. I am not sure if you have worked on it or not. If you have, you can push a draft PR so we have the work on remote. If not, that's fine, we can unassign you and revisit this when we are ready.

@github-actions github-actions bot removed the Stale label Jul 22, 2024
@wandergithub
Copy link
Contributor

I did start but was facing some errors/setbacks... It is most likely something I don't understand and I messed up. For now, I've been dealing with life so it is okay if you unassing me. I will get back to it when I have time.

@kasugaijin kasugaijin added the on hold Further investigation/decision-making is required label Jul 22, 2024
@kasugaijin
Copy link
Collaborator Author

@wandergithub ok no worries at all! I have unassigned you and placed this on hold for when we are ready to tackle this refactor after launch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Further investigation/decision-making is required
Projects
None yet
Development

No branches or pull requests

2 participants