Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for DefaultPetTask refactor #885

Open
kasugaijin opened this issue Jul 21, 2024 · 10 comments
Open

Add tests for DefaultPetTask refactor #885

kasugaijin opened this issue Jul 21, 2024 · 10 comments
Assignees
Labels

Comments

@kasugaijin
Copy link
Collaborator

@atbalaji if you want to take this on seeing as you worked on the PR, please assign yourself. Otherwise, let me know in a comment below and we can open it up to someone else.

PR

@atbalaji
Copy link
Contributor

Currently I'm not taking this @kasugaijin. I would like to revisit this incase no one else took this.

@kasugaijin
Copy link
Collaborator Author

@atbalaji all yours when you want it...just assign yourself.

@Aaryanpal
Copy link
Contributor

@kasugaijin can u please assign this

@kasugaijin
Copy link
Collaborator Author

@Aaryanpal no need to test front end that looks for DOM elements. Just backend model or controller level makes sense

@Aaryanpal
Copy link
Contributor

WIP

@Aaryanpal
Copy link
Contributor

WIP

@Aaryanpal
Copy link
Contributor

@kasugaijin I am not getting any clue for what use case i need to write the Test Cases.
Any Help Will be Highly Appreciated.

@kasugaijin
Copy link
Collaborator Author

@Aaryanpal the original PR added species to the default pet task service, so it would be good to have some tests where we set task A on dogs and task B on cats and make sure they are assigned to cats and dogs when they are created

@Aaryanpal
Copy link
Contributor

Thanks for the Guidance @kasugaijin.
Raised the PR

Copy link

github-actions bot commented Nov 9, 2024

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the Stale label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants