Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oraganization::Staff look in view files to see if any text should be moved to translation files #983

Closed
kasugaijin opened this issue Sep 18, 2024 · 2 comments
Closed

Oraganization::Staff look in view files to see if any text should be moved to translation files #983

kasugaijin opened this issue Sep 18, 2024 · 2 comments
Assignees
@italomatos

Comments

@kasugaijin
Copy link
Collaborator

We have tried to be disciplined in making sure view text is sourced from a translation file, but there are places where we did not do this. This task is to look through the view files for the Organization::Staff scope to see if there is any text, and add them to the en.yml following the existing format.
@kasugaijin kasugaijin added the Ready Make a comment to get assigned. label Sep 18, 2024
@italomatos
Copy link
Contributor

hey @kasugaijin could you assign this to me?

@kasugaijin kasugaijin removed the Ready Make a comment to get assigned. label Sep 21, 2024
@italomatos italomatos mentioned this issue Sep 22, 2024
Merged
@italomatos
Copy link
Contributor

hey @kasugaijin I opened new PR about this issue
PR: https://github.com/rubyforgood/pet-rescue/pull/995/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@italomatos italomatos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@italomatos @kasugaijin