Address reviewer feedback

Signed-off-by: Michael Carroll <[email protected]>

Author: mjcarroll

include/ignition/gazebo/Actor.hh

@@ -609,10 +609,6 @@ See https://github.com/gazebosim/gz-sim/issues/168 for more info."
                         options['wait_gui'], options['render_engine_gui'],
                         options['render_engine_gui_api_backend'])
       end
-    rescue
-      puts "Library error: Problem running [#{options['command']}]() "\
-        "from #{plugin}."
-    # begin
     end
   # execute
   end

include/ignition/gazebo/Joint.hh

@@ -21,18 +21,18 @@
 
 /// \brief External hook to read the library version.
 /// \return C-string representing the version. Ex.: 0.1.2
-extern "C" GZ_SIM_VISIBLE char *gzSimVersion();
+extern "C" GZ_SIM_GZ_VISIBLE char *gzSimVersion();
 
 /// \brief Get the Gazebo version header.
 /// \return C-string containing the Gazebo version information.
-extern "C" GZ_SIM_VISIBLE char *simVersionHeader();
+extern "C" GZ_SIM_GZ_VISIBLE char *simVersionHeader();
 
 /// \brief Set verbosity level
 /// \param[in] _verbosity 0 to 4
-extern "C" GZ_SIM_VISIBLE void cmdVerbosity(
+extern "C" GZ_SIM_GZ_VISIBLE void cmdVerbosity(
     const char *_verbosity);
 
-extern "C" GZ_SIM_VISIBLE const char *worldInstallDir();
+extern "C" GZ_SIM_GZ_VISIBLE const char *worldInstallDir();
 
 /// \brief External hook to run simulation server.
 /// \param[in] _sdfString SDF file to run, as a string.
@@ -62,7 +62,7 @@ extern "C" GZ_SIM_VISIBLE const char *worldInstallDir();
 /// \param[in] _recordPeriod --record-period option
 /// \param[in] _seed --seed value to be used for random number generator.
 /// \return 0 if successful, 1 if not.
-extern "C" GZ_SIM_VISIBLE int runServer(const char *_sdfString,
+extern "C" GZ_SIM_GZ_VISIBLE int runServer(const char *_sdfString,
     int _iterations, int _run, float _hz, double _initialSimTime, int _levels,
     const char *_networkRole, int _networkSecondaries, int _record,
     const char *_recordPath, int _recordResources, int _logOverwrite,
@@ -82,16 +82,17 @@ extern "C" GZ_SIM_VISIBLE int runServer(const char *_sdfString,
 /// \param[in] _renderEngine --render-engine-gui option
 /// \param[in] _renderEngineGuiApiBackend --render-engine-gui-api-backend option
 /// \return 0 if successful, 1 if not.
-extern "C" GZ_SIM_VISIBLE int runGui(const char *_guiConfig, const char *_file,
-                                     int _waitGui,
-                                     const char *_renderEngine,
-                                     const char *_renderEngineGuiApiBackend);
+extern "C" GZ_SIM_GZ_VISIBLE
+int runGui(const char *_guiConfig, const char *_file,
+           int _waitGui,
+           const char *_renderEngine,
+           const char *_renderEngineGuiApiBackend);
 
 /// \brief External hook to find or download a fuel world provided a URL.
 /// \param[in] _pathToResource Path to the fuel world resource, ie,
 /// https://staging-fuel.gazebosim.org/1.0/gmas/worlds/ShapesClone
 /// \return C-string containing the path to the local world sdf file
-extern "C" GZ_SIM_VISIBLE const char *findFuelResource(
+extern "C" GZ_SIM_GZ_VISIBLE const char *findFuelResource(
     char *_pathToResource);
 
 #endif

include/ignition/gazebo/Light.hh

@@ -93,7 +93,7 @@ blender [blender options] file.blend
 4. Run the script using the *Run script* button in the panel of the
    *Text Editor* tab at the top of the screen.
 
-@image html https://github.com/gazebosim/gz-sim/tree/main/tutorials/files/blender_procedural_datasets/blender_instructions.png "Instructions in Blender" width=100%
+![Instructions in Blender](https://raw.githubusercontent.com/gazebosim/gz-sim/main/tutorials/files/blender_procedural_datasets/blender_instructions.png)
 
 Once you follow these steps and configure the script for your `.blend` project,
 you can save it and use Option B in the future.