Merge pull request #31 from run-as-root/develop

cristiano-pacheco · web-flow · commit 46e188fe0321 · 2023-05-16T10:06:20.000-03:00
Changes to skip the message retry
diff --git a/src/Plugin/HandleQueueMessageRejectPlugin.php b/src/Plugin/HandleQueueMessageRejectPlugin.php
@@ -36,7 +36,7 @@ public function aroundReject(
         }
 
         if (str_contains($rejectionMessage, 'MESSAGE_QUEUE_SKIP_RETRY')) {
-            $proceed($envelope, $requeue, $rejectionMessage);
+            $subject->acknowledge($envelope);
             return;
         }
 
diff --git a/src/Test/Unit/Plugin/HandleQueueMessageRejectPluginTest.php b/src/Test/Unit/Plugin/HandleQueueMessageRejectPluginTest.php
@@ -107,7 +107,7 @@ public function testItShouldSkipRetryWhenExceptionMessageContainsAnUniqueIdentif
             $exceptionMessage
         );
 
-        self::assertTrue($this->isProceedCalled);
+        self::assertFalse($this->isProceedCalled);
     }
 
     public function skipRetryDataProvider(): array

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public function aroundReject(`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`if (str_contains($rejectionMessage, 'MESSAGE_QUEUE_SKIP_RETRY')) {`
`39`		`- $proceed($envelope, $requeue, $rejectionMessage);`
	`39`	`+ $subject->acknowledge($envelope);`
`40`	`40`	`return;`
`41`	`41`	`}`
`42`	`42`
Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ public function testItShouldSkipRetryWhenExceptionMessageContainsAnUniqueIdentif`
`107`	`107`	`$exceptionMessage`
`108`	`108`	`);`
`109`	`109`
`110`		`- self::assertTrue($this->isProceedCalled);`
	`110`	`+ self::assertFalse($this->isProceedCalled);`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`public function skipRetryDataProvider(): array`