gitconfig credential.helper error: Resource busy

[kpettijohn]

It seems with the changes made in #203 Atlantis now throws an error when attempting to modify the git config.

https://github.com/runatlantis/helm-charts/pull/203/files#diff-a3b675e5633e3d9602003c23ede42b91c32bc10f4aed39235b204cff10c11bbdL131

{"level":"error","ts":"2022-12-02T16:15:07.444Z","caller":"events/command_runner.go:169","msg":"Error running pre-workflow hooks There was an error running git config --global credential.helper store: error: could not write config file /home/atlantis/.gitconfig: Resource busy\n: exit status 4. Proceeding with plan command."}

Overall I believe this is due to changing the mount path to be /home/atlantis/.gitconfig instead of mounting the file to /etc/secret-gitconfig and copying the file to /home/atlantis/.gitconfig. This causes the /home/atlantis/.gitconfig file to be read only so when Atlantis attempts to run git config --global credential.helper store it results in the error Resource busy.

It seems due to this error it causes all additional pre workflow hooks to be skipped which causes additional issues. I'm not totally sure what the best path forward is here. In our setup we include the git credential configuration as part of the gitconfig.

            gitconfig: |
              [credential]
                helper = store
              [url "https://[email protected]"]
                insteadOf = ssh://[email protected]
              [url "https://[email protected]/"]
                insteadOf = [email protected]:

Any ideas to fix or work around the issue would be appreciated!

[nitrocode]

Thanks @kpettijohn for bringing this to our attention.

@kpettijohn @nxf5025 could you see if there is a small change to fix this?

[GMartinez-Sisti]

Possible fix on #384. Please review.

[bdellegrazie]

Just FYI, this isn't fixed as the volume mount is still mounted read-only.

[GMartinez-Sisti]

Just FYI, this isn't fixed as the volume mount is still mounted read-only.

Yes! We are aware of that 😓 Recent discussions were here. Re-opening !

[GMartinez-Sisti]

Hi! Please take a look at #407, to confirm this fixes the issue. 🙏

[qdm12]

Hello there,
I am facing the same issue but on another project (bind mounting .gitconfig in a dev container).
@kpettijohn you mention

This causes the /home/atlantis/.gitconfig file to be read only

Why is that? Why is mounting directly to ~/.gitconfig making this read-only for git?? In my case I bind mount without forcing read-only in a container with -v /home/user/.gitconfig:/home/user/.gitconfig and get that resource busy error as well. Is bind mounting making git unable to modify the file? On top of this, manually editing the file (i.e. with vi) works fine...

[mubarak-j]

@qdm12 I'm not sure why read-only is the default but you can override it using gitconfigReadOnly: true in the helm values which was added in v5.4.1 of this chart