fix(serverless): fail file() on HTTP error responses

file() saved whatever body came back, so a 4xx/5xx error page was written
as the downloaded file and, when the URL ended in .zip, handed to the
extractor. download_files_from_urls already called raise_for_status();
file() never did.

Behavior change: file() now raises requests.RequestException on an error
status instead of returning a dict pointing at the error page. It has no
in-tree callers and is not re-exported from serverless.utils, so this is
limited to direct importers.

Author: deanq

runpod/serverless/utils/rp_download.py

@@ -134,6 +134,10 @@ def file(file_url: str) -> dict:
     os.makedirs("job_files", exist_ok=True)
 
     with safe_get(file_url, stream=True, timeout=30, headers=HEADERS) as download_response:
+        # Fail on an error response rather than saving the error page as the
+        # file; for a .zip that body would go straight to the extractor.
+        download_response.raise_for_status()
+
         content_disposition = download_response.headers.get("Content-Disposition")
 
         original_file_name = ""

tests/test_serverless/test_utils/test_download.py

@@ -234,6 +234,26 @@ def test_download_file_with_malformed_content_length(self, mock_file, mock_get):
         self.assertEqual(result["type"], "txt")
         mock_file().write.assert_called_once_with(b"file content")
 
+    @patch("runpod.serverless.utils.rp_download.safe_get")
+    @patch("builtins.open", new_callable=mock_open)
+    @patch("runpod.serverless.utils.rp_download.zipfile.ZipFile")
+    def test_download_file_raises_on_http_error(self, mock_zip, mock_file, mock_get):
+        """
+        An error response must not be saved as if it were the file: a 404 body
+        written to a .zip would then be handed to the extractor.
+        """
+        mock_get.return_value = MockResponse(
+            b"<html>404 Not Found</html>",
+            404,
+            {"Content-Disposition": "filename=test_file.zip"},
+        )
+
+        with self.assertRaises(RequestException):
+            file("http://test.com/test_file.zip")
+
+        mock_file().write.assert_not_called()
+        mock_zip.assert_not_called()  # and the error page never reaches the extractor
+
     @patch("runpod.serverless.utils.rp_download.safe_get")
     @patch("builtins.open", new_callable=mock_open)
     @patch("runpod.serverless.utils.rp_download.zipfile.ZipFile")