Skip to content

Commit 813784a

Browse files
committed
refactor(serverless): replace print() with logger in upload fallback paths
Address Copilot review comment from PR #466: Replace print() statements with logger.warning() for consistency with the module's logging setup. This allows proper log level control and maintains consistent logging behavior throughout the module. Changes: - upload_image(): Use logger.warning() instead of print() - upload_file_to_bucket(): Use logger.warning() instead of print() - upload_in_memory_object(): Use logger.warning() instead of print() All fallback messages now use structured logging with single-line format for better log parsing and filtering.
1 parent 841488b commit 813784a

2 files changed

Lines changed: 12 additions & 12 deletions

File tree

‎runpod/serverless/modules/rp_scale.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ async def get_jobs(self, session: ClientSession):
195195

196196
except TooManyRequests:
197197
log.debug(
198-
f"JobScaler.get_jobs | Too many requests. Debounce for 5 seconds."
198+
"JobScaler.get_jobs | Too many requests. Debounce for 5 seconds."
199199
)
200200
await asyncio.sleep(5) # debounce for 5 seconds
201201
except asyncio.CancelledError:

‎runpod/serverless/utils/rp_upload.py‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -133,11 +133,11 @@ def upload_image(
133133

134134
if boto_client is None:
135135
# Save the output to a file
136-
print("No bucket endpoint set, saving to disk folder 'simulated_uploaded'")
137-
print("If this is a live endpoint, please reference the following:")
138-
print(
136+
logger.warning(
137+
"No bucket endpoint set, saving to disk folder 'simulated_uploaded'. "
138+
"If this is a live endpoint, please reference: "
139139
"https://github.com/runpod/runpod-python/blob/main/docs/serverless/utils/rp_upload.md"
140-
) # pylint: disable=line-too-long
140+
)
141141

142142
os.makedirs("simulated_uploaded", exist_ok=True)
143143
sim_upload_location = f"simulated_uploaded/{image_name}{file_extension}"
@@ -261,11 +261,11 @@ def upload_file_to_bucket(
261261
key = f"{prefix}/{file_name}" if prefix else file_name
262262

263263
if boto_client is None:
264-
print("No bucket endpoint set, saving to disk folder 'local_upload'")
265-
print("If this is a live endpoint, please reference the following:")
266-
print(
264+
logger.warning(
265+
"No bucket endpoint set, saving to disk folder 'local_upload'. "
266+
"If this is a live endpoint, please reference: "
267267
"https://github.com/runpod/runpod-python/blob/main/docs/serverless/utils/rp_upload.md"
268-
) # pylint: disable=line-too-long
268+
)
269269

270270
os.makedirs("local_upload", exist_ok=True)
271271
local_upload_location = f"local_upload/{file_name}"
@@ -316,9 +316,9 @@ def upload_in_memory_object(
316316
key = f"{prefix}/{file_name}" if prefix else file_name
317317

318318
if boto_client is None:
319-
print("No bucket endpoint set, saving to disk folder 'local_upload'")
320-
print("If this is a live endpoint, please reference the following:")
321-
print(
319+
logger.warning(
320+
"No bucket endpoint set, saving to disk folder 'local_upload'. "
321+
"If this is a live endpoint, please reference: "
322322
"https://github.com/runpod/runpod-python/blob/main/docs/serverless/utils/rp_upload.md"
323323
)
324324

0 commit comments

Comments
 (0)