[FSSDK-10619] Refactor project config manager to be injectable (optimizely#945)

Author: raju-opti

lib/common_exports.ts

@@ -1,5 +1,5 @@
 /**
- * Copyright 2023 Optimizely
+ * Copyright 2023-2024 Optimizely
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -17,3 +17,5 @@
 export { LogLevel, LogHandler, getLogger, setLogHandler } from './modules/logging';
 export { LOG_LEVEL } from './utils/enums';
 export { createLogger } from './plugins/logger';
+export { createStaticProjectConfigManager } from './project_config/config_manager_factory';
+export { PollingConfigManagerConfig } from './project_config/config_manager_factory';

lib/core/bucketer/index.tests.js

@@ -1,5 +1,5 @@
 /**
- * Copyright 2016-2017, 2019-2022, Optimizely
+ * Copyright 2016-2017, 2019-2022, 2024, Optimizely
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -25,7 +25,7 @@ import {
   LOG_LEVEL,
 } from '../../utils/enums';
 import { createLogger } from '../../plugins/logger';
-import projectConfig from '../project_config';
+import projectConfig from '../../project_config/project_config';
 import { getTestProjectConfig } from '../../tests/test_data';
 
 var buildLogMessageFromArgs = args => sprintf(args[1], ...args.splice(2));

lib/core/decision_service/index.tests.js

@@ -1,18 +1,18 @@
-/****************************************************************************
- * Copyright 2017-2022 Optimizely, Inc. and contributors                    *
- *                                                                          *
- * Licensed under the Apache License, Version 2.0 (the "License");          *
- * you may not use this file except in compliance with the License.         *
- * You may obtain a copy of the License at                                  *
- *                                                                          *
- *    http://www.apache.org/licenses/LICENSE-2.0                            *
- *                                                                          *
- * Unless required by applicable law or agreed to in writing, software      *
- * distributed under the License is distributed on an "AS IS" BASIS,        *
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. *
- * See the License for the specific language governing permissions and      *
- * limitations under the License.                                           *
- ***************************************************************************/
+/**
+ * Copyright 2017-2022, 2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 import sinon from 'sinon';
 import { assert } from 'chai';
 import cloneDeep from 'lodash/cloneDeep';
@@ -29,11 +29,13 @@ import { createForwardingEventProcessor } from '../../plugins/event_processor/fo
 import { createNotificationCenter } from '../notification_center';
 import Optimizely from '../../optimizely';
 import OptimizelyUserContext from '../../optimizely_user_context';
-import projectConfig from '../project_config';
+import projectConfig, { createProjectConfig } from '../../project_config/project_config';
 import AudienceEvaluator from '../audience_evaluator';
 import errorHandler from '../../plugins/error_handler';
 import eventDispatcher from '../../plugins/event_dispatcher/index.node';
 import * as jsonSchemaValidator from '../../utils/json_schema_validator';
+import { getMockProjectConfigManager } from '../../tests/mock/mock_project_config_manager';
+
 import {
   getTestProjectConfig,
   getTestProjectConfigWithFeatures,
@@ -1067,7 +1069,9 @@ describe('lib/core/decision_service', function() {
     beforeEach(function() {
       optlyInstance = new Optimizely({
         clientEngine: 'node-sdk',
-        datafile: cloneDeep(testData),
+        projectConfigManager: getMockProjectConfigManager({
+          initConfig: createProjectConfig(cloneDeep(testData))
+        }),
         jsonSchemaValidator: jsonSchemaValidator,
         isValidInstance: true,
         logger: createdLogger,

lib/core/decision_service/index.ts

@@ -1,18 +1,18 @@
-/****************************************************************************
- * Copyright 2017-2022 Optimizely, Inc. and contributors                    *
- *                                                                          *
- * Licensed under the Apache License, Version 2.0 (the "License");          *
- * you may not use this file except in compliance with the License.         *
- * You may obtain a copy of the License at                                  *
- *                                                                          *
- *    http://www.apache.org/licenses/LICENSE-2.0                            *
- *                                                                          *
- * Unless required by applicable law or agreed to in writing, software      *
- * distributed under the License is distributed on an "AS IS" BASIS,        *
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. *
- * See the License for the specific language governing permissions and      *
- * limitations under the License.                                           *
- ***************************************************************************/
+/**
+ * Copyright 2017-2022, 2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 import { LogHandler } from '../../modules/logging';
 import { sprintf } from '../../utils/fns';
 
@@ -38,7 +38,7 @@ import {
   getVariationKeyFromId,
   isActive,
   ProjectConfig,
-} from '../project_config';
+} from '../../project_config/project_config';
 import { AudienceEvaluator, createAudienceEvaluator } from '../audience_evaluator';
 import * as stringValidator from '../../utils/string_value_validator';
 import {

lib/core/event_builder/event_helpers.tests.js

@@ -1,5 +1,5 @@
 /**
- * Copyright 2019-2020, Optimizely
+ * Copyright 2019-2020, 2024, Optimizely
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -17,7 +17,7 @@ import sinon from 'sinon';
 import { assert } from 'chai';
 
 import fns from '../../utils/fns';
-import * as projectConfig from '../project_config';
+import * as projectConfig from '../../project_config/project_config';
 import * as decision from '../decision';
 import { buildImpressionEvent, buildConversionEvent } from './event_helpers';
 

lib/core/event_builder/event_helpers.ts

@@ -1,5 +1,5 @@
 /**
- * Copyright 2019-2022, Optimizely
+ * Copyright 2019-2022, 2024, Optimizely
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -27,7 +27,7 @@ import {
   getEventId,
   getLayerId,
   ProjectConfig,
-} from '../project_config';
+} from '../../project_config/project_config';
 
 const logger = getLogger('EVENT_BUILDER');
 

lib/core/event_builder/index.tests.js

@@ -1,5 +1,5 @@
 /**
- * Copyright 2016-2021, Optimizely
+ * Copyright 2016-2021, 2024, Optimizely
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -18,7 +18,7 @@ import { assert } from 'chai';
 
 import fns from '../../utils/fns';
 import testData from '../../tests/test_data';
-import projectConfig from '../project_config';
+import projectConfig from '../../project_config/project_config';
 import packageJSON from '../../../package.json';
 import { getConversionEvent, getImpressionEvent } from './';
 

lib/core/event_builder/index.ts

@@ -1,5 +1,5 @@
 /**
- * Copyright 2016-2022, Optimizely
+ * Copyright 2016-2022, 2024, Optimizely
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -24,7 +24,7 @@ import {
   getLayerId,
   getVariationKeyFromId,
   ProjectConfig,
-} from '../project_config';
+} from '../../project_config/project_config';
 import * as eventTagUtils from '../../utils/event_tag_utils';
 import { isAttributeValid } from '../../utils/attributes_validator';
 import { EventTags, UserAttributes, Event as EventLoggingEndpoint } from '../../shared_types';

lib/core/notification_center/notification_registry.tests.ts

@@ -16,7 +16,7 @@
 
 import { LogHandler, LogLevel } from '../../modules/logging';
 import { OdpEvent } from './odp_event';
-import { RequestHandler } from '../../utils/http_request_handler/http';
+import { HttpMethod, RequestHandler } from '../../utils/http_request_handler/http';
 import { OdpConfig } from './odp_config';
 import { ERROR_MESSAGES } from '../../utils/enums';
 
@@ -109,7 +109,7 @@ export abstract class OdpEventApiManager implements IOdpEventApiManager {
     odpConfig: OdpConfig,
     events: OdpEvent[]
   ): {
-    method: string;
+    method: HttpMethod;
     endpoint: string;
     headers: { [key: string]: string };
     data: string;

lib/core/notification_center/notification_registry.ts

@@ -24,7 +24,7 @@ import { OdpConfig } from './odp_config';
 import { IOdpEventApiManager } from './odp_event_api_manager';
 import { invalidOdpDataFound } from './odp_utils';
 import { IUserAgentParser } from './user_agent_parser';
-import { scheduleMicrotaskOrTimeout } from '../../utils/microtask';
+import { scheduleMicrotask } from '../../utils/microtask';
 
 const MAX_RETRIES = 3;
 
@@ -394,7 +394,7 @@ export abstract class OdpEventManager implements IOdpEventManager {
 
     if (batch.length > 0) {
       // put sending the event on another event loop
-      scheduleMicrotaskOrTimeout(async () => {
+      scheduleMicrotask(async () => {
         let shouldRetry: boolean;
         let attemptNumber = 0;
         do {

lib/core/odp/odp_event_api_manager.ts

@@ -1,5 +1,5 @@
 /**
- * Copyright 2019-2021, Optimizely
+ * Copyright 2019-2021, 2024, Optimizely
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -18,7 +18,7 @@ import { cloneDeep } from 'lodash';
 import sinon from 'sinon';
 
 import { createOptimizelyConfig, OptimizelyConfig } from './';
-import { createProjectConfig } from '../project_config';
+import { createProjectConfig } from '../../project_config/project_config';
 import {
   getTestProjectConfigWithFeatures,
   getTypedAudiencesConfig,

lib/core/odp/odp_event_manager.ts

@@ -1,5 +1,5 @@
 /**
- * Copyright 2020-2023, Optimizely
+ * Copyright 2020-2024, Optimizely
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 import { LoggerFacade, getLogger } from '../../modules/logging';
-import { ProjectConfig } from '../project_config';
+import { ProjectConfig } from '../../project_config/project_config';
 import { DEFAULT_OPERATOR_TYPES } from '../condition_tree_evaluator';
 import {
   Audience,