Changelog #211

Author: lnicola

generated_assists.adoc

@@ -923,7 +923,7 @@ fn qux(bar: Bar, baz: Baz) {}
 
 [discrete]
 === `extract_expressions_from_format_string`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/extract_expressions_from_format_string.rs#L13[extract_expressions_from_format_string.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/extract_expressions_from_format_string.rs#L14[extract_expressions_from_format_string.rs]
 
 Move an expression out of a format string.
 
@@ -1073,7 +1073,7 @@ fn main() {
 
 [discrete]
 === `fix_visibility`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/fix_visibility.rs#L12[fix_visibility.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/fix_visibility.rs#L14[fix_visibility.rs]
 
 Makes inaccessible item public.
 
@@ -1251,7 +1251,7 @@ impl Default for Example {
 
 [discrete]
 === `generate_delegate_methods`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_delegate_methods.rs#L16[generate_delegate_methods.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_delegate_methods.rs#L17[generate_delegate_methods.rs]
 
 Generate delegate methods.
 
@@ -1631,7 +1631,7 @@ impl From<u32> for A {
 
 [discrete]
 === `generate_function`
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_function.rs#L27[generate_function.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/generate_function.rs#L28[generate_function.rs]
 
 Adds a stub function with a signature matching the function under the cursor.
 

generated_diagnostic.adoc

@@ -56,13 +56,13 @@ This diagnostic is shown when the derive attribute has invalid input.
 
 
 === mismatched-arg-count
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/mismatched_arg_count.rs#L30[mismatched_arg_count.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/mismatched_arg_count.rs#L31[mismatched_arg_count.rs]
 
 This diagnostic is triggered if a function is invoked with an incorrect amount of arguments.
 
 
 === mismatched-tuple-struct-pat-arg-count
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/mismatched_arg_count.rs#L10[mismatched_arg_count.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/mismatched_arg_count.rs#L11[mismatched_arg_count.rs]
 
 This diagnostic is triggered if a function is invoked with an incorrect amount of arguments.
 
@@ -88,7 +88,7 @@ This diagnostic is triggered if `match` block is missing one or more match arms.
 
 
 === missing-unsafe
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/missing_unsafe.rs#L9[missing_unsafe.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/missing_unsafe.rs#L10[missing_unsafe.rs]
 
 This diagnostic is triggered if an operation marked as `unsafe` is used outside of an `unsafe` function or block.
 
@@ -148,6 +148,12 @@ Diagnoses missing trait items in a trait impl.
 Only traits defined in the current crate can be implemented for arbitrary types
 
 
+=== trait-impl-redundant-assoc_item
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/trait_impl_redundant_assoc_item.rs#L6[trait_impl_redundant_assoc_item.rs]
+
+Diagnoses redundant trait items in a trait impl.
+
+
 === type-mismatch
 **Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/type_mismatch.rs#L11[type_mismatch.rs]
 
@@ -180,7 +186,7 @@ crates rust-analyzer failed to discover. The file will not have IDE features ava
 
 
 === unnecessary-braces
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/useless_braces.rs#L9[useless_braces.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-diagnostics/src/handlers/useless_braces.rs#L12[useless_braces.rs]
 
 Diagnostic for unnecessary braces in `use` items.
 

generated_features.adoc

@@ -221,7 +221,7 @@ image::https://user-images.githubusercontent.com/48062697/113020654-b42fc800-917
 
 
 === Find All References
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/references.rs#L43[references.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/references.rs#L45[references.rs]
 
 Shows all references of the item at the cursor location
 
@@ -303,7 +303,7 @@ image::https://user-images.githubusercontent.com/48062697/113065566-02f85480-91b
 
 
 === Go to Type Definition
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/goto_type_definition.rs#L6[goto_type_definition.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/goto_type_definition.rs#L7[goto_type_definition.rs]
 
 Navigates to the type of an identifier.
 
@@ -317,7 +317,7 @@ image::https://user-images.githubusercontent.com/48062697/113020657-b560f500-917
 
 
 === Highlight Related
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/highlight_related.rs#L40[highlight_related.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/highlight_related.rs#L41[highlight_related.rs]
 
 Highlights constructs related to the thing under the cursor:
 
@@ -332,7 +332,7 @@ Note: `?`, `|` and `->` do not currently trigger this behavior in the VSCode edi
 
 
 === Hover
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/hover.rs#L97[hover.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/hover.rs#L98[hover.rs]
 
 Shows additional information, like the type of an expression or the documentation for a definition when "focusing" code.
 Focusing is usually hovering with a mouse, but can also be triggered with a shortcut.
@@ -341,7 +341,7 @@ image::https://user-images.githubusercontent.com/48062697/113020658-b5f98b80-917
 
 
 === Inlay Hints
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/inlay_hints.rs#L424[inlay_hints.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/inlay_hints.rs#L425[inlay_hints.rs]
 
 rust-analyzer shows additional information inline with the source code.
 Editors usually render this using read-only virtual text snippets interspersed with code.
@@ -554,7 +554,7 @@ image::https://user-images.githubusercontent.com/48062697/113171066-105c2000-923
 
 
 === Open Docs
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/doc_links.rs#L121[doc_links.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/doc_links.rs#L123[doc_links.rs]
 
 Retrieve a links to documentation for the given symbol.
 
@@ -598,7 +598,7 @@ the selected item. The context menu opens. Select **Peek Related Tests**.
 
 
 === Rename
-**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/rename.rs#L73[rename.rs]
+**Source:** https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/rename.rs#L72[rename.rs]
 
 Renames the item below the cursor and all of its references
 

thisweek/_posts/2023-12-11-changelog-211.adoc

@@ -0,0 +1,59 @@
+= Changelog #211
+:sectanchors:
+:experimental:
+:page-layout: post
+
+Commit: commit:457b966b171b09a7e57acb710fbca29a4b3526f0[] +
+Release: release:2023-12-11[] (`v0.3.1766`)
+
+== New Features
+
+* pr:15959[] replace TokenMap with an abstraction that matches reality.
+* pr:16027[] add support for implicit format args:
++
+video::https://user-images.githubusercontent.com/308347/289476161-20bcb7f6-cfa2-4550-a2ba-a524ab52cba3.mp4[options=loop]
+* pr:16034[] support multiple navigation targets when the focus range is in the macro definition site:
++
+image::https://user-images.githubusercontent.com/3757771/288381131-2cc82e5c-320f-4de2-9d55-fe975d180f2a.gif["Screen recording showing two Go to definition results for `tcx.def_span` in the rustc source code"]
+* pr:15990[] diagnose extra trait impl items:
++
+image::https://user-images.githubusercontent.com/308347/289478906-01ab50b3-ad41-482c-8b33-62712efb89e4.png["Screenshot showing an error on a trait impl item that's not a member of original trait"]
+* pr:15627[] prioritize import suggestions based on the expected type:
++
+image::https://user-images.githubusercontent.com/308347/289481260-3325f8cd-8cb5-4a12-8ec7-b2554309dc14.png["Screenshot showing the flyimport pop-up prioritizing `std::sync::atomic::Ordering` in a `fetch_add` call"]
+
+== Fixes
+
+* pr:15896[] (first contribution) show placeholder while getting runnable list from server:
++
+image::https://user-images.githubusercontent.com/16928427/282953072-09de6a1c-6f3c-4d29-8031-ba4baeb43282.png["Screenshot showing a `Looking for runnables...` in the picker before `cargo test` and `cargo check` show up"]
+* pr:15515[] (first contribution) improve handling of binary expressions on the left-hand side of "Flip binary expression".
+* pr:16009[] (first contribution) don't search for `ControlFlow` as string in "Extract function".
+* pr:16028[] make drop inlay hints more readable:
++
+image::https://user-images.githubusercontent.com/71162630/288081867-bb18707f-3278-435d-a938-ccff4c685586.png["Screenshot showing drop hints appearing now after the semicolon"]
+* pr:16024[] fix runnables working directory on Windows.
+* pr:16054[] fix token downmapping being quadratic.
+* pr:16016[] don't insert parantheses around fields in struct literals.
+* pr:16041[] fix `WideChar` offsets calculation in `line-index`.
+* pr:16073[] replace `doc_comments_and_attrs` with `collect_attrs`.
+* pr:16035[] fix diagnostics panicking when resolving to different files due to macros.
+* pr:16037[] don't print proc-macro panic backtraces in the logs.
+* pr:15486[] fix item tree lowering `pub(self)` to `pub()`.
+* pr:15705[] resolve Self type references in delegate method assist.
+* pr:16048[] fix `concat_bytes!` expansion emitting an identifier.
+* pr:16058[] reduce spans for unresolved field and method diagnostics.
+* pr:16060[] fix completion in `format_args!` with invalid template.
+* pr:16078[] fix "View Mir", "View Hir" and "Interpret function" when the caret is inside a macro.
+* pr:16039[] don't emit missing items diagnostic for negative impls.
+* pr:16045[] fix panic with closure inside array length.
+* pr:16055[] fall back to method resolution on unresolved field access.
+
+== Internal Improvements
+
+* pr:16036[] (first contribution) make `ParamLoweringMode` accessible.
+* pr:15986[] use `triomphe::Arc::from_iter`.
+* pr:16042[] bump `salsa`.
+* pr:16022[] don't explicitly warn against `semicolon_in_expressions_from_macros`.
+* pr:16038[] publish `lsp-server 0.7.5`.
+* pr:16043[] bump and unlock some dependencies.